Hi Dorinda, On Sun, Jan 24, 2021 at 02:55:58PM +0100, Dorinda wrote: > added a sanity check to verify if bitbake is present in PATH > > Fixes: https://bugzilla.yoctoproject.org/show_bug.cgi?id=13822# >
I think the convention is: [YOCTO #13822] c.f.: https://wiki.yoctoproject.org/wiki/Bugzilla_Configuration_and_Bug_Tracking A little word in the commit log and/or comment in the class to explain how this could happen would be great so one does not have to read the bugzilla entry to understand why this fix is needed. > Signed-off-by: Dorinda Bassey <[email protected]> > --- > meta/classes/sanity.bbclass | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass > index d134b40a87..2040b48595 100644 > --- a/meta/classes/sanity.bbclass > +++ b/meta/classes/sanity.bbclass > @@ -787,6 +787,11 @@ def check_sanity_everybuild(status, d): > if "." in paths or "./" in paths or "" in paths: > status.addresult("PATH contains '.', './' or '' (empty element), > which will break the build, please remove this.\nParsed PATH is " + > str(paths) + "\n") > > + #Check if bitbake is present in path > + bb_check = bb.utils.which(d.getVar('PATH'), 'bitbake') > + if not bb_check: > + bb.warn("bitbake binary is not found in path, did you source the > script?") > + I'd personally put PATH all uppercase, it is then obvious we're talking about the PATH environment variable used to locate executables. That's just me nitpicking however. Otherwise, I don't think this patch is needed by the rest of the patch series? If I'm correct, then ideally you should have sent it as part of a second patch series or just sent it directly to the mailing list. Usually a patch series is for a bug fix or a new feature, or follows a specific theme (e.g. backports from one release to another, or straightforward recipe upgrades). If the feature requires a bug fix, then you add the bug fix to the feature patch series. If you have multiple themes, unrelated bug fixes or features, it's usually better to have separate patch series so that if there's a discussion about one particular patch, the other patches can still be merged fast by maintainers (easier to keep track which patches are merged by just not merging any patch of a series which is under discussion). Thanks, Quentin
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#147161): https://lists.openembedded.org/g/openembedded-core/message/147161 Mute This Topic: https://lists.openembedded.org/mt/80077937/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
