Thanks for the feedbacks, will update the patch. Dorinda
On Jan 25, 2021 3:58 PM, "Peter Kjellerstedt" <[email protected]> wrote: > > -----Original Message----- > > From: [email protected] <openembedded- > > [email protected]> On Behalf Of Quentin Schulz > > Sent: den 25 januari 2021 10:22 > > To: Dorinda <[email protected]> > > Cc: [email protected] > > Subject: Re: [OE-core] [PATCH 5/5] sanity.bbclass: verify that user isn't > > building in PSEUDO_IGNORE_PATHS > > > > Hi Dorinda, > > > > On Sun, Jan 24, 2021 at 02:55:59PM +0100, Dorinda wrote: > > > added a check to ensure that a user isn't building in > > PSEUDO_IGNORE_PATHS > > > > > > > Missing [YOCTO #14179] tag I think :) > > > > > Signed-off-by: Dorinda Bassey <[email protected]> > > > --- > > > meta/classes/sanity.bbclass | 7 +++++++ > > > 1 file changed, 7 insertions(+) > > > > > > diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass > > > index 2040b48595..78c0343f0d 100644 > > > --- a/meta/classes/sanity.bbclass > > > +++ b/meta/classes/sanity.bbclass > > > @@ -703,6 +703,13 @@ def check_sanity_version_change(status, d): > > > if (tmpdirmode & stat.S_ISUID): > > > status.addresult("TMPDIR is setuid, please don't build in a > setuid directory") > > > > > > + # Check that user isn't building in PSEUDO_IGNORE_PATHS > > > + pseudoignorepaths = d.getVar('PSEUDO_IGNORE_PATHS', > expand=True).split(",") > > > + workdir = d.getVar('WORKDIR', expand=True) > > > + for i in pseudoignorepaths: > > > + if workdir.startswith(i): > > PSEUDO_IGNORE_PATHS may contain empty paths (i.e., from multiple > consecutive commas, or a trailing commas). Pseudo will ignore these > paths, so this code should ignore them too: > > if i and workdir.startswith(i): > > > > + status.addresult("you are building in a path under > PSEUDO_IGNORE_PATHS, please remove this" + str(i) + "directory in \nParsed > WORKDIR: " + str(workdir) + "\n") > > > > Capital Y for the beginning of the sentence? > > > > Missing space before and after str(i). > > > > I'm not familiar with this part of the code, so forgive me if this is > > wrong but... is your sentence finished? > > > > You are building in a path under PSEUDO_IGNORE_PATHS, please remove this > <dir> directory in > > Parsed WORKDIR: <workdir> > > > > That is to me not very telling about what I should do to fix this issue. > > > > I honestly might be missing a lot of context on the issue so wouldn't be > > surprised if the issue is with me not understanding the sentence more > > than the sentence being "unfinished". > > No, I don't think you are wrong. I do not understand it either. > > > Thanks, > > Quentin > > //Peter > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#147225): https://lists.openembedded.org/g/openembedded-core/message/147225 Mute This Topic: https://lists.openembedded.org/mt/80077947/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
