> -----Original Message-----
> From: [email protected] <openembedded-
> [email protected]> On Behalf Of Richard Purdie
> Sent: den 27 januari 2021 18:28
> To: [email protected]
> Subject: [OE-core] [PATCH 6/7] native: Stop clearing PACKAGES
>
> Native recipes have been special and they don't have packages generated
> from them. The RDEPENDS/RPROVIDES and other runtime package specific
> variables can contain important data about dependencies recipes need
> though and currently it is required to write this information explicitly
> in the native case.
>
> We now delete the packaging tasks for native recipes which removes the
> need to clear PACKAGES. The next step to improve the metadata is to
> stop clearing it and ensure any entries in these variables are remapped
> appropriately. The R* variables were already being processed by the class
> extension code but the implementation was suboptimal.
>
> This patch stops clearing PACKAGES and PACKAGES_DYNAMIC and fixes the
> places
> where that caused issues in OE-Core, for example PACKAGES additions in
> anonymous
> python without the "-native" suffix and a case where the included classes
> caused a self reference in DEPENDS which would once have been removed by
> the previous code.
>
> The implementation uses datastore/parser parameters to ensure that the
> variable overrides are not overwritten when calling setVar which is
> appropriate
> for a function as close to the core as this one is.
>
> Some now unneeded code in python3-setuptools is dropped, there are
> further
> changes like this which can follow.
>
> This change was verified with OE-Core by comparing task-depends.dot
> generated
> by "bitbake world -g" before and after the change, the files were
> identical.
>
> Signed-off-by: Richard Purdie <[email protected]>
> ---
> meta/classes/native.bbclass | 23 ++++++++-----------
> .../python/python3-setuptools_51.0.0.bb | 5 ----
> .../gdk-pixbuf/gdk-pixbuf_2.40.0.bb | 1 +
> meta/recipes-support/boost/boost.inc | 3 +++
> 4 files changed, 13 insertions(+), 19 deletions(-)
>
[cut]
> diff --git a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.40.0.bb
> b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.40.0.bb
> index 16708fd581d..226e1c7b89f 100644
> --- a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.40.0.bb
> +++ b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.40.0.bb
> @@ -13,6 +13,7 @@ LIC_FILES_CHKSUM =
> "file://COPYING;md5=4fbd65380cdd255951079008b364516c \
> SECTION = "libs"
>
> DEPENDS = "glib-2.0 gdk-pixbuf-native shared-mime-info"
> +DEPENDS_remove_class-native = "gdk-pixbuf-native"
Given that I know you want to avoid using _remove in OE-Core, is there
any reason to not write this as:
DEPENDS = "glib-2.0 shared-mime-info"
DEPENDS_append_class-target = " gdk-pixbuf-native"
DEPENDS_append_class-nativesdk = " gdk-pixbuf-native"
(I'm not sure the append for nativesdk should be there, but I added it
to match the original code.)
>
> MAJ_VER = "${@oe.utils.trim_version("${PV}", 2)}"
>
//Peter
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#147665):
https://lists.openembedded.org/g/openembedded-core/message/147665
Mute This Topic: https://lists.openembedded.org/mt/80162703/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
