On Thu, 2021-02-04 at 19:43 +0000, Peter Kjellerstedt wrote: > > > > diff --git a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.40.0.bb > > b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.40.0.bb > > index 16708fd581d..226e1c7b89f 100644 > > --- a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.40.0.bb > > +++ b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.40.0.bb > > @@ -13,6 +13,7 @@ LIC_FILES_CHKSUM = " > > file://COPYING;md5=4fbd65380cdd255951079008b364516c \ > > SECTION = "libs" > > > > DEPENDS = "glib-2.0 gdk-pixbuf-native shared-mime-info" > > +DEPENDS_remove_class-native = "gdk-pixbuf-native" > > Given that I know you want to avoid using _remove in OE-Core, is > there > any reason to not write this as: > > DEPENDS = "glib-2.0 shared-mime-info" > DEPENDS_append_class-target = " gdk-pixbuf-native" > DEPENDS_append_class-nativesdk = " gdk-pixbuf-native"
That would be better, yes. I'll admit with this series I was dealing with a lot of weird issues so the end result still could use some improvement. There are probably a few places in the metadata we could improve now. > (I'm not sure the append for nativesdk should be there, but I added > it to match the original code.) I'd suspect the nativesdk is needed. Cheers, Richard
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#147666): https://lists.openembedded.org/g/openembedded-core/message/147666 Mute This Topic: https://lists.openembedded.org/mt/80162703/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
