On 3/22/21 4:29 PM, Alexander Kanavin wrote:
**[Please note: This e-mail is from an EXTERNAL e-mail address]

Note that this m4 file is copied verbatim from upstream gettext, and will be again overwritten on next gettext upgrade. You should figure out what’s wrong specifically in elfutils tree, and work with elfutils upstream to resolve it.

Hi Alex,

The reason why we care out iconv.m4 is because want to keep the logic in https://git.openembedded.org/openembedded-core/commit/?id=3dd269e027fda173ee40d671ea47da22300fd51d which oe specific.

I think there is nothing wrong for elfutils switches to use AM_GNU_GETTEXT.

Thanks,


Alex

On Mon 22. Mar 2021 at 10.51, Yu, Mingli <mingli...@windriver.com <mailto:mingli...@windriver.com>> wrote:

    From: Mingli Yu <mingli...@windriver.com
    <mailto:mingli...@windriver.com>>

    The below m4 macros files shipped with recipe will be removed if the
    recipe use AM_GNU_GETTEXT.
    gettext.m4
    iconv.m4
    lib-ld.m4
    lib-link.m4
    lib-prefix.m4
    nls.m4 po.m4
    progtest.m4

    After elfutils upgrades to 0.183, it begins to use AM_GNU_GETTEXT as the
    commit (dd52d2ab Modernize gettext infrastructure) included, so the
    above
    m4 macros files such as iconv.m4 is removed and it's bad as we need to
    patch against iconv.m4 shipped with elfutils.

    BTW, the logic to Disable the unnecessary check in iconv.m4 comes since
    2015 as [1], so move the related logic to gettext-minimal which provides
    iconv.m4 now to fix the gap.

    [1]
    
https://git.openembedded.org/openembedded-core/commit/?id=3dd269e027fda173ee40d671ea47da22300fd51d

    Signed-off-by: Mingli Yu <mingli...@windriver.com
    <mailto:mingli...@windriver.com>>
    ---
      meta/recipes-core/gettext/gettext-minimal-0.21/aclocal/iconv.m4 | 2 ++
      1 file changed, 2 insertions(+)

    diff --git
    a/meta/recipes-core/gettext/gettext-minimal-0.21/aclocal/iconv.m4
    b/meta/recipes-core/gettext/gettext-minimal-0.21/aclocal/iconv.m4
    index e593b7270a..e04476bb7f 100644
    --- a/meta/recipes-core/gettext/gettext-minimal-0.21/aclocal/iconv.m4
    +++ b/meta/recipes-core/gettext/gettext-minimal-0.21/aclocal/iconv.m4
    @@ -166,6 +166,7 @@ AC_DEFUN([AM_ICONV_LINK],
            }
        }
      #endif
    +#if 0
        /* Test against HP-UX 11.11 bug: No converter from EUC-JP to
    UTF-8 is
           provided.  */
        {
    @@ -189,6 +190,7 @@ AC_DEFUN([AM_ICONV_LINK],
          if (cd4 != (iconv_t)(-1))
            iconv_close (cd4);
        }
    +#endif
        return result;
      ]])],
                [am_cv_func_iconv_works=yes], ,
-- 2.17.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#149771): 
https://lists.openembedded.org/g/openembedded-core/message/149771
Mute This Topic: https://lists.openembedded.org/mt/81519074/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to