Hi Richard,

>> The patch was tested and then merged but we can update the patch header with
>> more info if we have it.
Thanks for clarification.

Updated the patch header with additional info,
===========================
This patch is cherry picked from commit
95b91a043aeaeb546d2fea556d84a2de1e917770 on binutils-2_36-branch.

The original patches are discussed at,
https://sourceware.org/bugzilla/show_bug.cgi?id=26945#c14
https://sourceware.org/bugzilla/show_bug.cgi?id=26945#c15
===========================

Sent v2 patch with suggested corrections for review.

Regards,
Vinay

On Thu, May 6, 2021 at 6:19 PM Richard Purdie
<[email protected]> wrote:
>
> On Thu, 2021-05-06 at 17:55 +0530, Vinay Kumar wrote:
> > Hi Anuj,
> >
> > Thanks for the feedback.
> >
> > > > This doesn't look like a cherry pick of: 
> > > > https://github.com/bminor/binutils-gdb/commit/d3edaa91d4cf7202ec14342410194841e2f67f12
> > > > What else is in there?
> >
> > cherry picked commit ids in the below order to "SRCREV" of 
> > binutils-2.36.inc.
> >
> > 1. 8e03235147a9e774d3ba084e93c2da1aa94d1cec
> > 2. d3edaa91d4cf7202ec14342410194841e2f67f12
> > 3. 8b69e61d4be276bb862698aaafddc3e779d23c8f
> >
> > Direct cherry-pick of "d3edaa91d4cf7202ec14342410194841e2f67f12" into
> > "SRCREV" gives errors due to the changes in arsup.c file. So used
> > 8e03235147a9e774d3ba084e93c2da1aa94d1cec (binutils: Avoid renaming
> > over existing files).
> >
> > The commit id 8b69e61d4be276bb862698aaafddc3e779d23c8f is
> > to fix the binutils build error with Mingw.
> >
> > > > Also this didn't apply on hardknott and I had to rebase it. Please also
> > > > use b in the subject for binutils.
> >
> > Will send a v2 patch with corrections.
>
> The patch was tested and then merged but we can update the patch header with
> more info if we have it.
>
> I'd assumed the differences were due to the smart_rename disabling/renabling
> the patch mentioned.
>
> Cheers,
>
> Richard
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#151405): 
https://lists.openembedded.org/g/openembedded-core/message/151405
Mute This Topic: https://lists.openembedded.org/mt/82452876/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to