On 1/8/22 11:27, Bruce Ashfield wrote:
On Fri, Jan 7, 2022 at 6:19 PM Richard Purdie
<richard.pur...@linuxfoundation.org
<mailto:richard.pur...@linuxfoundation.org>> wrote:
On Fri, 2022-01-07 at 13:24 -0800, Saul Wold wrote:
> Move the do_strip() functionality to a more common location in the
> package split_and_strip_files() flow. This makes it possible for the
> extended packaging data to be generated correctly for the kernel and
> kernel modules. The KERNEL_IMAGE_STRIP_EXTRA_SECTIONS is reused in
> the runstrip() part of package stripping.
>
> Signed-off-by: Saul Wold <saul.w...@windriver.com
<mailto:saul.w...@windriver.com>>
> ---
> meta/classes/kernel.bbclass | 35 +++--------------------------------
> 1 file changed, 3 insertions(+), 32 deletions(-)
As I mentioned in previous mails, I think this will mean the
do_deploy output
will change and become unstripped which may cause a problem for some
platforms.
We likely need to keep a strip task but call the new strip function
from it?
I personally think this is a reasonable direction apart from that
though, at
least in principle.
Agreed. It looks ok to me as well, with us making sure that do_deploy
can remain as it was.
I have been looking into this and realized it's maybe a little more
complex since the do_sizecheck() needs to run also before do_deploy.
Currently, I believe the ordering is:
do_compile()
do_compile_kernelmodules()
do_kernel_linux_images()
do_strip()
do_sizecheck()
do_install
do_package()
do_packagedata()
do_deploy()
If I move the strip() process to package, I also have to move when
do_sizecheck() runs. As you mention we need to keep what gets deployed
to be the same with and without the package split_and_strip_files().
I understand what your talking about having the vmlinux image (which is
the one getting stripped) is the same before and after this changeset, I
don't think it's an issue of the deployed vmlinux being un-stripped but
the vmlinux being stripped in the deploy dir.
We can't really call the package.bbclass strip from the kernel bbclass
since it's part of the package process and called in a multiprocess() way.
One thought is to have a copy of the vmlinux that gets packaged and
stripped via the package process vs the vmlinux binary that gets
deployed and optionally stripped when KERNEL_IMAGE_STRIP_EXTRA_SECTIONS
is set.
Maybe we can talk though this during the Tech call Tuesday.
Sau!
Bruce
Cheers,
Richard
--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
--
Sau!
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#160382):
https://lists.openembedded.org/g/openembedded-core/message/160382
Mute This Topic: https://lists.openembedded.org/mt/88271781/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
