On Tue, Apr 26, 2022 at 1:56 PM Khem Raj <raj.k...@gmail.com> wrote: > > On Tue, Apr 26, 2022 at 1:51 PM Andre McCurdy <armccu...@gmail.com> wrote: > > > > On Tue, Apr 26, 2022 at 12:46 PM Nicolas Dechesne > > <nicolas.deche...@linaro.org> wrote: > > > > > > This is a follow up patch of: > > > ad5829aa1f8a (sanity: Show a warning that make 4.2.1 is buggy on > > > non-ubuntu systems) > > > > > > Debian10 has the exact same version/sources for make as Ubuntu > > > (focal), e.g. https://packages.debian.org/source/buster/make-dfsg and > > > https://packages.ubuntu.com/source/focal/make-dfsg. > > > > > > As per the corresponding changelog, the patch mentioned in > > > ad5829aa1f8a, is included in both Debian and Ubuntu in make > > > 4.2.1-1.1. So it's safe to use make 4.2.1 in Debian10. > > > > > > Signed-off-by: Nicolas Dechesne <nicolas.deche...@linaro.org> > > > --- > > > meta/classes/sanity.bbclass | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass > > > index c385d92e8b..c72a7b3ed3 100644 > > > --- a/meta/classes/sanity.bbclass > > > +++ b/meta/classes/sanity.bbclass > > > @@ -470,7 +470,7 @@ def check_make_version(sanity_data): > > > > > > if bb.utils.vercmp_string_op(version, "4.2.1", "=="): > > > distro = oe.lsb.distro_identifier() > > > > Not directly related to your change, but shouldn't this be > > lsb_distro_identifier() instead of oe.lsb.distro_identifier()? > > lsb_distro_identifier would work when it is inheriting base.bbclass > otherwise the utility function is needed.
Question isn't really whether it will work or not (if it doesn't work, we should make it work) but rather whether any user-defined LSB_DISTRO_ADJUST should be applied before checking if the host distro is based on Debian/Ubuntu or not. > > > - if "ubuntu" in distro: > > > + if "ubuntu" in distro or "debian" in distro: > > > return None > > > return "make version 4.2.1 is known to have issues on > > > Centos/OpenSUSE and other non-Ubuntu systems. Please use a > > > buildtools-make-tarball or a newer version of make.\n" > > > return None > > > -- > > > 2.36.0 > > > > > > > > > > > > > > > > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#164885): https://lists.openembedded.org/g/openembedded-core/message/164885 Mute This Topic: https://lists.openembedded.org/mt/90716488/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
