Hi Willy
Thanks for the patch!
On 10/21/22 15:17, Willy Tu via lists.openembedded.org wrote:
Install API only if opensshinternals is in DISTRO_FEATURES.
Install the OpenSSH header + lib files for other repo to build using it.
For example, https://github.com/google/hiba is dependent on those files
to build and this change is needed to meet that requirement.
https://github.com/openembedded/meta-openembedded/pull/597
Signed-off-by: Willy Tu <[email protected]>
---
meta/recipes-connectivity/openssh/openssh_9.0p1.bb | 11 +++++++++++
1 file changed, 11 insertions(+)
There's a problem with the way you send your patches though. I used to
have it too.
If I apply your patch through "git am", the author of the commit will be:
Willy Tu via lists.openembedded.org <[email protected]>
instead of
Willy Tu <[email protected]>
Because of this issue, the maintainer has to manually fix this field
when accepting your patch. Worse, if he doesn't catch this, that's
harder to fix afterwards.
You should be able to fix this by running:
git config --global sendemail.from "[email protected]"
This should add a "From" field to the sent patch which "git am" should
be able to match with your name.
At least this worked for me. See
https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded#Sending_using_git-send-email
Could you try to send an update? You could send it to me again through
private-email first.
Thanks in advance
Michael.
--
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#172035):
https://lists.openembedded.org/g/openembedded-core/message/172035
Mute This Topic: https://lists.openembedded.org/mt/94475279/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
