Thanks Alexander for the feedback, We had some discussion internally with one of the OpenSSH maintainers and they are fine with it. I'll try to see if there is a public forum where we can share the discussion.
Willy Tu On Tue, Nov 8, 2022 at 8:27 AM Alexander Kanavin <[email protected]> wrote: > > The correct way to do this is to discuss the issue with openssh > upstream, and provide a link to any such discussion if it has already > happened. If they don't want to install these things, they have > reasons, and you need to at least try to convince them otherwise. > > We generally do not go against upstream choices. > > Alex > > On Tue, 8 Nov 2022 at 17:23, Willy Tu via lists.openembedded.org > <[email protected]> wrote: > > > > Is there anything else that I need to do to help move this forward? > > > > Willy Tu > > > > On Mon, Oct 31, 2022 at 8:42 AM Willy Tu via lists.openembedded.org > > <[email protected]> wrote: > >> > >> Friendly ping. Is there any more concern on this? > >> > >> Willy Tu > >> > >> > >> On Mon, Oct 24, 2022 at 10:07 AM Willy Tu via lists.openembedded.org > >> <[email protected]> wrote: > >> > > >> > Testing it out more and it seems like the current change is fine in that > >> > regard. > >> > > >> > I was building it against an OpenBMC image which include the change and > >> > the header and libssh.a files doesn't show up in the image itself > >> > > >> > ``` > >> > ./tmp/work/izumi-openbmc-linux-gnueabi/obmc-phosphor-image > >> > ``` > >> > doesn't have those files. I believe that's what we are looking for? > >> > > >> > Willy Tu > >> > > >> > On Mon, Oct 24, 2022 at 9:05 AM Willy Tu via lists.openembedded.org > >> > <[email protected]> wrote: > >> >> > >> >> I am testing it out again and it seems like it does install to the > >> >> target . > >> >> > >> >> ``` > >> >> $ find -name libssh.a > >> >> ./tmp/sysroots-components/armv7a/openssh/usr/lib/libssh.a > >> >> ./tmp/work/armv7a-openbmc-linux-gnueabi/openssh/9.0p1-r0/image/usr/lib/libssh.a > >> >> ./tmp/work/armv7a-openbmc-linux-gnueabi/openssh/9.0p1-r0/sysroot-destdir/usr/lib/libssh.a > >> >> ./tmp/work/armv7a-openbmc-linux-gnueabi/openssh/9.0p1-r0/packages-split/openssh-staticdev/usr/lib/libssh.a > >> >> ./tmp/work/armv7a-openbmc-linux-gnueabi/openssh/9.0p1-r0/openssh-9.0p1/libssh.a > >> >> ./tmp/work/armv7a-openbmc-linux-gnueabi/openssh/9.0p1-r0/package/usr/lib/libssh.a > >> >> ./tmp/work/armv7a-openbmc-linux-gnueabi/hiba/1.0+gitAUTOINC+3199239c6a-r0/recipe-sysroot/usr/lib/libssh.a > >> >> ``` > >> >> We don't want this, right? > >> >> > >> >> I'll have to try to figure it out and fix it. > >> >> > >> >> Willy Tu > >> >> > >> >> On Mon, Oct 24, 2022 at 7:57 AM Tristan Lelong <[email protected]> > >> >> wrote: > >> >>> > >> >>> > >> >>> > >> >>> On Fri, Oct 21, 2022 at 6:22 PM Willy Tu <[email protected]> wrote: > >> >>>> > >> >>>> Hi Ross, > >> >>>> > >> >>>> Thanks for the feedback. > >> >>>> > >> >>>> Can you point to the right repo to update? Just to make sure that I > >> >>>> understand the concern, you are not referring to > >> >>>> https://github.com/openembedded/meta-openembedded/pull/597, right? I > >> >>>> am making changes to > >> >>>> http://cgit.openembedded.org/openembedded-core/tree/meta/recipes-connectivity/openssh/openssh_9.0p1.bb > >> >>>> which I thought is part of oe-core. > >> >>>> > >> >>>> @Tristan Lelong is the maintainer for hiba and is okay with the > >> >>>> change. Do you have any suggestions on installing it to just the > >> >>>> sysroot in openssh while using it from the hiba recipe? I was not > >> >>>> able to do that when I tried it. > >> >>> > >> >>> > >> >>> This was indeed discussed previously in another version of the patch, > >> >>> it seemed the best way to expose OpenSSH's internal files was via the > >> >>> devel package (not installed on the target), rather than hook into > >> >>> another package's syroot. > >> >>> > >> >>> The OpenSSH static libraries and header files are currently not made > >> >>> officially available because the API is not considered stable enough, > >> >>> but exporting them in OE for HIBA (gated by a PACKAGECONFIG) in order > >> >>> to support HIBA is fine. > >> >>> > >> >>>> > >> >>>> > >> >>>> Thanks, > >> >>>> > >> >>>> Willy Tu > >> >>>> > >> >>>> > >> >>>> > >> >>>> > >> >>>> On Fri, Oct 21, 2022 at 7:59 AM Ross Burton <[email protected]> > >> >>>> wrote: > >> >>>>> > >> >>>>> Hi, > >> >>>>> > >> >>>>> oe-core doesn’t accept merge requests on the github mirrors, and you > >> >>>>> pushed to meta-oe, which is a different repository. > >> >>>>> > >> >>>>> >> + if ${@bb.utils.contains('DISTRO_FEATURES', 'opensshinternals', > >> >>>>> >> 'true', 'false', d)}; then > >> >>>>> > >> >>>>> This should be a PACKAGECONFIG, as it’s not a distro-wide setting. > >> >>>>> > >> >>>>> >> + install -d ${D}${includedir}/ssh > >> >>>>> >> + install -d ${D}${includedir}/ssh/openbsd-compat > >> >>>>> >> + install -m0644 ${S}/*.h ${D}${includedir}/ssh > >> >>>>> >> + install -m0644 ${S}/openbsd-compat/*.h > >> >>>>> >> ${D}${includedir}/ssh/openbsd-compat > >> >>>>> >> + > >> >>>>> >> + install -d ${D}${libdir} > >> >>>>> >> + install -m0644 ${S}/libssh.a ${D}${libdir} > >> >>>>> >> + install -m0644 ${S}/openbsd-compat/libopenbsd-compat.a > >> >>>>> >> ${D}${libdir} > >> >>>>> >> + fi > >> >>>>> > >> >>>>> So you’re installing bits of the SSH source into the *target* > >> >>>>> packages because one piece of software needs the build tree. This is > >> >>>>> clearly an unsupported use of openssh, as the hiba build > >> >>>>> instructions literally say “build openssh, then point hiba’s > >> >>>>> configure at that build tree”. If > >> >>>>> > >> >>>>> I suggest a better approach would be to have a bbappend in your > >> >>>>> layer which adds the files you need to *just the sysroot*, so the > >> >>>>> target packages are unaltered. > >> >>>>> > >> >>>>> Ross > >> >>> > >> >>> > >> >>> > >> >>> -- > >> >>> Tristan Lelong | SRE | [email protected] | > >> >> > >> >> > >> >> > >> >> > >> > > >> > > >> > > >> > >> > >> > > > > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#172982): https://lists.openembedded.org/g/openembedded-core/message/172982 Mute This Topic: https://lists.openembedded.org/mt/94475279/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
