On 3 Nov 2022, at 05:39, Chase Qi via lists.openembedded.org 
<[email protected]> wrote:
> +MIRRORS += "git://nsz.repo.hu:49100/repo/libc-test 
> git://repo.or.cz/libc-test"

Why do this recipe need a MIRRORS?

> +RDEPENDS:${PN}-ptest = " \
> +    bash \
> +    grep \
> +    musl \
> +    packagegroup-core-buildessential \
> +    sed \
> +"
> +
> +do_install_ptest () {
> +    cp ${S}/Makefile ${D}${PTEST_PATH}
> +    cp ${S}/config.mak.def ${D}${PTEST_PATH}/config.mak
> +    cp -r ${S}/src ${D}${PTEST_PATH}/
> +}
> +
> +# libc-test-ptest depends on empty libc-test.
> +ALLOW_EMPTY:${PN} = "1"

It would be neater if the test suite was installed to libc-test, and 
libc-test-ptest simply contained the run-ptest script. This way the packaging 
reflects reality and you don’t need to set ALLOW_EMPTY.

Basically: the package contains a test suite, and a ptest harness.  If we ever 
move from ptest to something else then the libc-test package won’t change, just 
the harness will.

> +COMPATIBLE_HOST = "null"
> +COMPATIBLE_HOST:libc-musl = "(.*)"

Is there any value in running the test suite on glibc?

Ross

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#172629): 
https://lists.openembedded.org/g/openembedded-core/message/172629
Mute This Topic: https://lists.openembedded.org/mt/94751275/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to