Hi Ross, Thanks for the review.
On Thu, 3 Nov 2022 at 21:51, Ross Burton <[email protected]> wrote: > > On 3 Nov 2022, at 05:39, Chase Qi via lists.openembedded.org > <[email protected]> wrote: > > +MIRRORS += "git://nsz.repo.hu:49100/repo/libc-test > > git://repo.or.cz/libc-test" > > Why do this recipe need a MIRRORS? > The main repo looks like a personal repo hosted in a kind of self-maintained hosting service. It is owned by http://igor2.repo.hu/. The mirror is the official mirror documented on the wiki https://wiki.musl-libc.org/libc-test.html. I think it can be helpful when the main repo is unreachable. > > +RDEPENDS:${PN}-ptest = " \ > > + bash \ > > + grep \ > > + musl \ > > + packagegroup-core-buildessential \ > > + sed \ > > +" > > + > > +do_install_ptest () { > > + cp ${S}/Makefile ${D}${PTEST_PATH} > > + cp ${S}/config.mak.def ${D}${PTEST_PATH}/config.mak > > + cp -r ${S}/src ${D}${PTEST_PATH}/ > > +} > > + > > +# libc-test-ptest depends on empty libc-test. > > +ALLOW_EMPTY:${PN} = "1" > > It would be neater if the test suite was installed to libc-test, and > libc-test-ptest simply contained the run-ptest script. This way the packaging > reflects reality and you don’t need to set ALLOW_EMPTY. > > Basically: the package contains a test suite, and a ptest harness. If we > ever move from ptest to something else then the libc-test package won’t > change, just the harness will. > +1 Thanks for your proposal. I have submitted v2. Would you please take a look? > > +COMPATIBLE_HOST = "null" > > +COMPATIBLE_HOST:libc-musl = "(.*)" > > Is there any value in running the test suite on glibc? > I tried the test suite on glibc. It reported all tests passed, but I do see errors in the test log. I think it doesn't work well on glibc. Considering glibc has its own test suite, the 'meta/recipes-core/glibc/glibc-tests_2.36.bb', I think we should start with musl only. Thanks, Chase > Ross >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#172706): https://lists.openembedded.org/g/openembedded-core/message/172706 Mute This Topic: https://lists.openembedded.org/mt/94751275/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
