On Tue, 14 Feb 2023 at 09:28, Robert Yang <[email protected]> wrote: > self.pm.insert_feeds_uris(self.d.getVar('PACKAGE_FEED_URIS') or > "", > self.d.getVar('PACKAGE_FEED_BASE_PATHS') or "", > - self.d.getVar('PACKAGE_FEED_ARCHS')) > + self._get_feed_archs())
I have to say no to this. All three package manager-specific implementations of this function already handle the case of PACKAGE_FEED_ARCHS not being set. Are they doing the right thing? If they do, then this should not be necessary. If they do not, then the code in those implementations should be fixed,but not overriden like the patch does. Also, rootfs.py should not be mentioning any specific packaging format, that's what those classes are for. Alex
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#177130): https://lists.openembedded.org/g/openembedded-core/message/177130 Mute This Topic: https://lists.openembedded.org/mt/96955951/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
