Thanks Naveen,
With a large patch like this it would be good if you could provide a
cover letter that summarized what is different in v12, compared to v11.
I've looked at the diff and my summary is below. There are some changes
which I see but would benefit from an explanation.
Finally, please change your SOB line to @windriver.com.
Summary of what changed in v12:
=====================
Rebase Rust tests to 1.67.1.
Switch from ssh-server-openssh to ssh-server-dropbear.
--> Why?
I know you were having problems with scp not working for qemux86
but either server should work in theory.
Tell the Rust remote-test-server to bind to port 12345.
--> Why?
Also add: --exclude src/tools/rust-analyzer to testargs.
--> Why?
I don't object but ideally the commit log would explain this decision.
As far as the tests go, you've :
- added 3 more 'ignore-stage1' comments :
$ rg ignore-stage1 /tmp/rust-test-v11.eml | wc -l
41
$ rg ignore-stage1 /tmp/rust-test-v12.eml | wc -l
44
- added 20 more #[ignore] directives:
$ rg "ignore]" /tmp/rust-test-v11.eml | wc -l
4
$ rg "ignore]" /tmp/rust-test-v12.eml | wc -l
24
Those additional test skip directives doesn't change the overall pass
rate significantly
since the test suite has ~ 18,000 tests so they're find with me .
I think that's about it. Did I miss anything?
Key, very abbreviated differences b/w v11, v12 are shown below .
../Randy
+Tested for X86, X86-64, ARM, ARM64 and MIPS64 on CentOS release 6.10
+
Signed-off-by: pgowda <[email protected]>
Signed-off-by: Vinay Kumar <[email protected]>
---
meta/lib/oeqa/selftest/cases/rust.py | 54 ++
- meta/recipes-devtools/rust/rust-source.inc | 3 +-
- meta/recipes-devtools/rust/rust.inc | 1 +
- .../rust/rust/rust-oe-selftest.patch | 508 ++++++++++++++++++
- meta/recipes-devtools/rust/rust_1.63.0.bb | 5 +
- 5 files changed, 570 insertions(+), 1 deletion(-)
+ .../rust/files/rust-oe-selftest.patch | 736 ++++++++++++++++++
+ meta/recipes-devtools/rust/rust-source.inc | 1 +
+ meta/recipes-devtools/rust/rust_1.67.1.bb | 6 +
+ 4 files changed, 797 insertions(+)
create mode 100644 meta/lib/oeqa/selftest/cases/rust.py
- create mode 100644 meta/recipes-devtools/rust/rust/rust-oe-selftest.patch
+ create mode 100644 meta/recipes-devtools/rust/files/rust-oe-selftest.patch
diff --git a/meta/lib/oeqa/selftest/cases/rust.py
b/meta/lib/oeqa/selftest/cases/rust.py
new file mode 100644
-index 0000000000..e06ddaa6d7
+index 0000000000..f9889b840c
--- /dev/null
+++ b/meta/lib/oeqa/selftest/cases/rust.py
@@ -0,0 +1,54 @@
@@ -237,7 +239,7 @@
+ # build core-image-minimal with required packages
+ default_installed_packages = ["libgcc", "libstdc++",
"libatomic", "libgomp"]
+ features = []
-+ features.append('IMAGE_FEATURES += "ssh-server-openssh"')
++ features.append('IMAGE_FEATURES += "ssh-server-dropbear"')
+ features.append('CORE_IMAGE_EXTRA_INSTALL += "{0}"'.format("
".join(default_installed_packages)))
+ self.write_config("\n".join(features))
+ bitbake("core-image-minimal")
@@ -248,7 +250,7 @@
+ ssh = SSHControl(ip=qemu.ip, logfile=qemu.sshlog,
user="root")
+ ssh.copy_to(builddir + "/" +
"build/x86_64-unknown-linux-gnu/stage1-tools-bin/remote-test-server","~/")
+ # Execute remote-test-server on image through background ssh
-+ command = '~/remote-test-server -v remote'
++ command = '~/remote-test-server --bind 0.0.0.0:12345 -v'
--
# Randy MacLeod
# Wind River Linux
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#177621):
https://lists.openembedded.org/g/openembedded-core/message/177621
Mute This Topic: https://lists.openembedded.org/mt/97178295/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
