On Thu, 2023-02-23 at 22:50 +0000, Richard Purdie via lists.openembedded.org wrote: > On Thu, 2023-02-23 at 21:04 +0000, Richard Purdie via > lists.openembedded.org wrote: > > On Thu, 2023-02-23 at 13:55 -0500, Randy MacLeod wrote: > > > Thanks Naveen, > > > > > > With a large patch like this it would be good if you could provide a > > > cover letter that summarized what is different in v12, compared to > > > v11. > > > > > > I've looked at the diff and my summary is below. There are some > > > changes > > > which I see but would benefit from an explanation. > > > > > > Finally, please change your SOB line to @windriver.com. > > > > > > > Changelogs definitely help, thanks Randy! > > > > Thanks for putting this patch together Naveen, we are getting there. I > > ran this through the autobuilder and the good news is we only saw one > > failure related to the patch, in oe-selftest on an ARM host: > > > > https://autobuilder.yoctoproject.org/typhoon/#/builders/127/builds/1004 > > (from > > https://autobuilder.yoctoproject.org/typhoon/#/builders/83/builds/4962 > > ) > > > > We could disable the rust tests on arm host systems to get this to > > merge however ideally it would be fixed to run there properly as well. > > I'm not even sure this should actually be running there at all now I > > look at things. The other toolchain/machine specific tests are tagged > > as "machine", e.g. meta_ide.py has: > > > > @OETestTag("machine") > > class MetaIDE(OESelftestTestCase): > > > > or they're marked as @OETestTag("toolchain-user") or > > @OETestTag("toolchain-system") in the case of the glibc/gcc tests. The > > difference is how the tests are run so "toolchain-system" would be most > > appropriate for rust. This means that the tests are run per MACHINE > > target instead of once overall. > > > > The second issue I noticed is that the test results are not appearing > > in the test report. For the build above, this is here: > > > > https://autobuilder.yocto.io/pub/non-release/20230223-9/testresults/testresult-report.txt > > > > > > and I can't see the rust tests at all. This will need to be fixed > > before the patches can merge. It may be changing to be > > machine/toolchain might fix that, I don't remember the details. > > I found some time to check into this a little further. We definitely > need to mark the test as a toolchain-system test so it is run in the > right places. > > Aside from that, there is also no individual test result reporting in > place for it, either the test suite passes or it does not. > > With the gcc tests, you'll see there is the self.ptest_result() call > which logs the individual test pass/fail/skip value. We'll need to do > something similar with rust so we don't just have one overall > pass/fail.
I reran this with the OTTestTag set. With that set, the tests run in the correct places and we then see failures for x86, mips and ppc: https://autobuilder.yoctoproject.org/typhoon/#/builders/59/builds/6663 https://autobuilder.yoctoproject.org/typhoon/#/builders/60/builds/6682 https://autobuilder.yoctoproject.org/typhoon/#/builders/63/builds/6672 AssertionError: Command '['scp', '-o', 'UserKnownHostsFile=/dev/null', '-o', 'StrictHostKeyChecking=no', '-o', 'LogLevel=ERROR', '/home/pokybuild/yocto-worker/qemux86/build/build-st-2169186/tmp/work/core2-32-poky-linux/rust/1.67.1-r0/rustc-1.67.1-src/build/x86_64-unknown-linux-gnu/stage1-tools-bin/remote-test-server', '[email protected]:~/']' returned non-zero exit status 1: b'scp: dest open(""): No such file or directory\r\nscp: failed to upload file /home/pokybuild/yocto-worker/qemux86/build/build-st-2169186/tmp/work/core2-32-poky-linux/rust/1.67.1-r0/rustc-1.67.1-src/build/x86_64-unknown-linux-gnu/stage1-tools-bin/remote-test-server to' which might be because it is trying to copy a file from /x86_64- unknown-linux-gnu/ when it is a 32 bit target? Cheers, Richard
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#177661): https://lists.openembedded.org/g/openembedded-core/message/177661 Mute This Topic: https://lists.openembedded.org/mt/97178295/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
