On Tue, 2023-10-17 at 16:00 +0200, Lukas Funke wrote: > Hi Richard, > > On 17.10.2023 15:53, Richard Purdie wrote: > > On Tue, 2023-10-17 at 15:26 +0200, Lukas Funke wrote: > > > From: Lukas Funke <[email protected]> > > > > > > Signed-off-by: Lukas Funke <[email protected]> > > > --- > > > scripts/lib/recipetool/create_go.py | 730 ++++++++++++++++++++++++++++ > > > 1 file changed, 730 insertions(+) > > > create mode 100644 scripts/lib/recipetool/create_go.py > > > > > > diff --git a/scripts/lib/recipetool/create_go.py > > > b/scripts/lib/recipetool/create_go.py > > > new file mode 100644 > > > index 0000000000..e0254f111b > > > --- /dev/null > > > +++ b/scripts/lib/recipetool/create_go.py > > > @@ -0,0 +1,730 @@ > > > +# Recipe creation tool - go support plugin > > > +# > > > +# Copyright (C) 2023 Weidmueller GmbH & Co KG > > > +# Author: Lukas Funke <[email protected]> > > > +# > > > +# SPDX-License-Identifier: GPL-2.0-only > > > +# > > > +# Copyright (c) 2009 The Go Authors. All rights reserved. > > > +# > > > +# SPDX-License-Identifier: BSD-3-Clause > > > +# > > > > Can you clarify what this license information means please? Two > > different license identifier lines seems rather confusing and > > problematic. > > > > I've not looked into the rest of the patches yet, this just caught my > > eye. > > Some of the ideas/code was ported from the original golang code to > python here. Thus, I had to copy the license information as well (I > guess?). If this is wrong or could be written in another way please > provide an example how it's done.
If the code is close enough to the original to be based off it, the new code would be under the same license? We can't tell which is the old code and which is the new code so the license header is rather problematic and confusing so this does need to be fixed. Perhaps this means it is all under BSD-3-Clause? That sounds easier but we don't don't have a top level LICENSE.BSD-3-Clause to match this and I'd prefer to keep the code under MIT/GPL-2.0 and not add another license to the mix if we can help it. Or is the code sufficiently different that you can say you took inspiration from that code but the result is under GPL-2.0 as it was different enough you can license it as you wish, the original license becoming not relevant? Either way the header needs some explanation of where this other copyright comes from too. I would probably just credit it as a source of inspiration but I don't know how similar it is/isn't. Cheers, Richard
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#189364): https://lists.openembedded.org/g/openembedded-core/message/189364 Mute This Topic: https://lists.openembedded.org/mt/102017392/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
