-----Original Message-----
From: [email protected]
<[email protected]> On Behalf Of Marco Felsch via
lists.openembedded.org
Sent: Tuesday, November 28, 2023 23:48
To: [email protected]
Cc: [email protected]; [email protected]
Subject: [OE-core] [PATCH] json-c: fix icecc compilation
> Skip -Werror to make it possible to compile this recipe with ICECC else all
> fallthrough comments will be removed since we pre-process the files on the
> host before sending them to the compile nodes which then cause errors because
> of default -Werror switch.
>
> Fixes: caf64f85b5c5 ("json-c: update 0.13.1 - > 0.14")
> Signed-off-by: Marco Felsch <[email protected]>
> ---
> Hi,
>
> I'm not familar with the stable material but IMHO this would be somthing for
> kirkstone.
You need to send a separate patch for kirkstone as this one does not apply
there.
>
> Regards,
> Marco
>
> meta/recipes-devtools/json-c/json-c_0.17.bb | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/meta/recipes-devtools/json-c/json-c_0.17.bb
> b/meta/recipes-devtools/json-c/json-c_0.17.bb
> index f4b7a32cea01..20bcece7685d 100644
> --- a/meta/recipes-devtools/json-c/json-c_0.17.bb
> +++ b/meta/recipes-devtools/json-c/json-c_0.17.bb
> @@ -17,6 +17,9 @@ UPSTREAM_CHECK_REGEX = "json-c-(?P<pver>\d+(\.\d+)+)-\d+"
>
> RPROVIDES:${PN} = "libjson"
>
> +# Required for ICECC builds
> +EXTRA_OECMAKE = "-DDISABLE_WERROR=ON"
I don't like removing WERROR unconditionally which decreases quality checks.
Can we do it only in case ICECC is used?
Something like "${@'-DDISABLE_WERROR=ON' if bb.data.inherits_class(icecc, d)
else ''}"
> +
> inherit cmake ptest
>
> do_install_ptest() {
--
2.39.2
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#191430):
https://lists.openembedded.org/g/openembedded-core/message/191430
Mute This Topic: https://lists.openembedded.org/mt/102861457/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
