On 23-11-29, Alexander Kanavin wrote: > On Wed, 29 Nov 2023 at 10:36, Marco Felsch <[email protected]> wrote: > > > I don't like removing WERROR unconditionally which decreases quality > > > checks. > > > Can we do it only in case ICECC is used? > > > Something like "${@'-DDISABLE_WERROR=ON' if bb.data.inherits_class(icecc, > > > d) else ''}" > > > > Good point, but IMHO IMHO Werror builds are for the project itself. It's > > not oe-core's purpose to check each package that Werror builds do > > succeed else you would need to enable it for all packages. > > In general we remove -Werror wherever we see it. If all components had > it, every gcc version update would cause an unfixable mountain of > fails all over the place. And version updates for the components > themselves would cause non-deterministic native fails too, depending > on which gcc version the build host has. > > -Werror is something components should run only in their own CI.
Exactly :) So this patch is good for oe-core? Regards, Marco
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#191438): https://lists.openembedded.org/g/openembedded-core/message/191438 Mute This Topic: https://lists.openembedded.org/mt/102861457/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
