Hi Yannick,
Thanks for the patch.
Typo in the commit title: firmware and not firmaware.
Also, to be pedantic, you're not adding firmware for Intel 9260 modules,
you're moving the different pieces of firmware to a separate package.
On 3/13/24 16:39, Yannick Rodriguez via lists.openembedded.org wrote:
[You don't often get email from
[email protected]. Learn why this is
important at https://aka.ms/LearnAboutSenderIdentification ]
From: Yannick Rodriguez <[email protected]>
Intel 9260 wifi modules is a serie of wireless modules that need firmwares to
function correctly. The linux firmware recipe does not have a package of these
firmwares, and this commit add them.
Just to be pedantic, but linux-firmware has a package for it, it's just
happen to be a package where all the files that didn't match make it.
Which means it's several dozens of MB big, which isn't really nice :)
Also the commit log is usually wrapped at 72 characters, but I cannot
find where we put this in the contributor guide... if we even did put it
there.
Since this 9260 is a combo chip with both Bluetooth and WiFi, what about
adding a separate package for the bluetooth part as well?
https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/commit/?h=20220610&id=97339b3a1d3bf3e4c40d679896a27a25fa83765f
seems to indicate that we can have a
${PN}-ibt-18 package with all firmware/intel/ibt-18-*.ddc and
firmware/intel/ibt-18-*.sfi?
Looks good otherwise,
Cheers,
Quentin
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#197050):
https://lists.openembedded.org/g/openembedded-core/message/197050
Mute This Topic: https://lists.openembedded.org/mt/104908041/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
