Hi Yannick,
On 3/13/24 17:29, RODRIGUEZ Yannick wrote:
Hi Quentin,
Thanks for your review.
Should i resend a patch with the modification your sugest . It's possible to
just amend m'y patch ?
For the bluetooth part of the suggestion, a separate patch would be
welcome. Though it's a suggestion, just a "would be nice to have",
you're not required per-se to do it for the wifi part to be merged (at
least that's my opinion as a contributor).
I think it'd be good to send a new version of the patch with the small
changes in the wording in the commit title and commit log, so you don't
have to wait for the maintainers to confirm this is a required change.
Don't forget to add the v2 (well it's now v3 technically ;) ) to the
patch, c.f.
https://docs.yoctoproject.org/contributor-guide/submit-changes.html#taking-patch-review-into-account
for how to do it.
It's m'y first patch.
Congratulations :) Wishing you (and us) many more to come!
https://docs.yoctoproject.org/contributor-guide/index.html should help
you get started. If something isn't clear there (or wrong, or
misleading, or outdated, etc...), let us know (or send a patch for the
documentation :) ).
Cheers,
Quentin
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#197051):
https://lists.openembedded.org/g/openembedded-core/message/197051
Mute This Topic: https://lists.openembedded.org/mt/104908041/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
