On Tue, 9 Apr 2024 at 11:57, Marko, Peter <[email protected]> wrote: > > -----Original Message----- > From: Alexander Kanavin <[email protected]> > Sent: Tuesday, April 9, 2024 11:16 > To: Marko, Peter (ADV D EU SK BFS1) <[email protected]> > Cc: [email protected] > Subject: Re: [OE-core][PATCH] systemd: make predictable name mac policy > opt-out > > > On Mon, 8 Apr 2024 at 09:06, Peter Marko via lists.openembedded.org > > <[email protected]> wrote: > > > - file://0001-NamePolicy.patch \ > > > + ${@bb.utils.contains('PACKAGECONFIG', > > > + 'predictable-if-mac', 'file://0001-NamePolicy.patch', '', d)} \ > > > > Conditional patches are terrible for maintainability. Please make it a > > proper meson option, and submit upstream. > > > > Alex > > This patch has status upstream inappropriate. > Pushing something like that to upstream doesn't sound like a good plan.
It's inappropriate as it is now, but with a meson option it would be very appropriate. > What about reverting the inappropriate patch completely instead? I'm okay with that too. Please work this out with the patch author. Alex
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#198062): https://lists.openembedded.org/g/openembedded-core/message/198062 Mute This Topic: https://lists.openembedded.org/mt/105396950/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
