-----Original Message----- From: Richard Purdie <[email protected]> Sent: Friday, April 12, 2024 18:41 To: Marko, Peter (ADV D EU SK BFS1) <[email protected]>; Ross Burton <[email protected]>; Kanavin, Alexander (EXT) (Linutronix GmbH) <[email protected]>; [email protected] Cc: [email protected] Subject: Re: [OE-core][PATCH] systemd: make predictable name mac policy opt-out
> On Fri, 2024-04-12 at 13:47 +0000, Marko, Peter wrote: > > -----Original Message----- > > From: Ross Burton <[email protected]> > > Sent: Wednesday, April 10, 2024 18:00 > > To: Marko, Peter (ADV D EU SK BFS1) <[email protected]> > > Cc: [email protected] > > Subject: Re: [OE-core][PATCH] systemd: make predictable name mac > > policy opt-out > > > > > On 8 Apr 2024, at 08:04, Peter Marko via lists.openembedded.org > > > <[email protected]> wrote: > > > > + ${@bb.utils.contains('PACKAGECONFIG', 'predictable- > > > > if-mac', 'file://0001-NamePolicy.patch', '', d)} \ > > > > > > There’s a few other places which use the pni-names DISTRO_FEATURE > > > (which probably needs to be documented), this should respect that I > > > guess. > > > > Sent a v2, maybe it's more acceptable as it uses distro feature and > > does not conditionally patch the sources. > > FWIW I much prefer it thanks. > > > Note that I have added the pni-names condition only to the systemd > > part. > > If this is accepted, the components from the other 4 patches should > > follow this. > > I'm struggling to keep track of all the details but I think this is an > improvement so I've queued it. I have checked and I think we should be good now. The 5 commits introducing the pni changes were: - "init-ifupdown: add predictable interface names" - does not enable pni, just handles if it's enabled - found problems were fixed by "init-ifupdown: modify interfaces for busybox" and "packagegroup-core-boot: recommend ifupdown" - "eudev: modify predictable network if name search" - does not enable pmi, just handles if it's enabled - "eudev: allow for predictable network interface names" - guarded by pni-names - "qemuboot: predictable network interface names" - guarded by pni-names - "systemd: enable mac based names in NamePolicy" - guarded by pni-names now after my commit Peter > Cheers, > > Richard
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#198186): https://lists.openembedded.org/g/openembedded-core/message/198186 Mute This Topic: https://lists.openembedded.org/mt/105396950/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
