On 6/5/2024 9:19 PM, Steve Sakoman wrote:
CAUTION: This email comes from a non Wind River email account!
Do not click links or open attachments unless you recognize the sender and know
the content is safe.
On Wed, Jun 5, 2024 at 8:42 AM Randy MacLeod
<[email protected]> wrote:
On 2024-06-05 10:56 a.m., Hemraj, Deepthi via lists.openembedded.org wrote:
Regression testing was done and below are the test results:
After update (v13.3)
=== gcc Summary ===
# of expected passes 248620
# of unexpected failures 9
# of expected failures 2484
# of unresolved testcases 25028
# of unsupported tests 4145
Before update (v13.2)
=== gcc Summary ===
# of expected passes 148304
# of unexpected failures 15
# of expected failures 1420
# of unresolved testcases 25136
# of unsupported tests 2688
Here are the computed differences for each category:
Expected Passes: +100316
Unexpected Failures: -6
Expected Failures: +1064
Unresolved Testcases: -108
Unsupported Tests: +1457
(Thanks to ChatGPT 4o ! Please do present the differences next time to save
me, ChatGPT, and others from the task. )
Can you explain the huge increase expected passes?
i.e. did upstream really add ~100316 new tests?
Ah, you have a typo, and expected passes for 13.3 should be 148620, based on:
https://lists.openembedded.org/g/openembedded-core/message/200008
The number of unexpected failures has decreased so that's good.
Also, did you check on the build problems that Steve reported?
That should be discussed in a cover letter for v2, v3, ...
Please learn how to write a v2 cover letter and send that with git:
$ git send-email -1 --cover-letter
Also, I saved your v2 patch and tried to apply it to scarthgap HEAD and that
failed with:
I had no issues applying the patch when taken from patchworks, only at
build time when applying the CVE-2024-0151 patch:
CmdError('quilt --quiltrc
TOPDIR/tmp/work-shared/gcc-13.3.0-r0/recipe-sysroot-native/etc/quiltrc
push', 0, 'stdout: Applying patch CVE-2024-0151.patch
patching file gcc/config/arm/arm.cc
Hunk #1 succeeded at 19157 with fuzz 2 (offset -53 lines).
Hunk #2 succeeded at 23668 with fuzz 2 (offset -8 lines).
The next patch would create the file
gcc/testsuite/gcc.target/arm/cmse/extend-param.c,
which already exists! Applying it anyway.
patching file gcc/testsuite/gcc.target/arm/cmse/extend-param.c
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- rejects in file
gcc/testsuite/gcc.target/arm/cmse/extend-param.c
The next patch would create the file
gcc/testsuite/gcc.target/arm/cmse/extend-return.c,
which already exists! Applying it anyway.
patching file gcc/testsuite/gcc.target/arm/cmse/extend-return.c
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- rejects in file
gcc/testsuite/gcc.target/arm/cmse/extend-return.c
Patch CVE-2024-0151.patch can be reverse-applied
So I suspect that V3 of the patch needs to also remove
CVE-2024-0151.patch, since the version bump seems to include the fix.
Steve
Hi Steve,
I was able to reproduce the issue. since the patch CVE-2024-0151.patch was
added yesterday after I had committed the changes, the above issue was caused I
will send a V3 tomorrow. Thank you, Deepthi
$ git status
On branch scarthgap
Your branch is up to date with 'origin/scarthgap'.
$ git am /tmp/gcc-13.3-v2.eml
Applying: gcc : upgrade to v13.3
.git/rebase-apply/patch:121: trailing whitespace.
@@ -31,16 +31,16 @@
error: patch failed: meta/recipes-devtools/gcc/gcc-13.2.inc:65
error: meta/recipes-devtools/gcc/gcc-13.2.inc: patch does not apply
Patch failed at 0001 gcc : upgrade to v13.3
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Looking at the diff between v1 and v2, it seems that you have some line wrap
issues
and perhaps more. Please test for this by using git send-email to send to
yourself or
someone who is using a sane (non-MS Outlook) email client and save the patch
and apply it
to an unpatched poky repo.
Thanks,
../Randy
--
# Randy MacLeod
# Wind River Linux
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#200413):
https://lists.openembedded.org/g/openembedded-core/message/200413
Mute This Topic: https://lists.openembedded.org/mt/106504365/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
