Hello On Tue, Jun 25, 2024 at 08:30:46PM +0200, [email protected] wrote: > From: Max Krummenacher <[email protected]> > > When a user of devicetree.bbclass overrides setting S, e.g. to > git/overlays then having UNPACKDIR set to S results in that > git repo unpacked inside UNPACKDIR. Thus the sources are actually > in git/overlays/git/overlays rather than the expected git/overlays. > > Change the logic, so that S by default is set to UNPACKDIR, > but a user can change S to point to were the sources actually > will be. > > Fixes: 7a06069a041a ("devicetree.bbclass: switch away from S = WORKDIR")
Gentle ping. Any comments on this commit? For me the referenced commit causes a regression. If I understand it correctly it will do so for any user which uses the devicetree.bbclass and did set S to anything other than WORKDIR. I think this should be fixed here rather than any recipe which sets S also setting UNPACKDIR. Thanks. Max > Signed-off-by: Max Krummenacher <[email protected]> > --- > meta/classes-recipe/devicetree.bbclass | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/meta/classes-recipe/devicetree.bbclass > b/meta/classes-recipe/devicetree.bbclass > index 1806cb62cbf7..e5dbd9a85714 100644 > --- a/meta/classes-recipe/devicetree.bbclass > +++ b/meta/classes-recipe/devicetree.bbclass > @@ -40,8 +40,8 @@ PACKAGE_ARCH = "${MACHINE_ARCH}" > SYSROOT_DIRS += "/boot/devicetree" > FILES:${PN} = "/boot/devicetree/*.dtb /boot/devicetree/*.dtbo" > > -S = "${WORKDIR}/sources" > -UNPACKDIR = "${S}" > +UNPACKDIR = "${WORKDIR}/sources" > +S = "${UNPACKDIR}" > B = "${WORKDIR}/build" > > # Default kernel includes, these represent what are normally used for > in-kernel > -- > 2.42.0 > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#201422): https://lists.openembedded.org/g/openembedded-core/message/201422 Mute This Topic: https://lists.openembedded.org/mt/106875716/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
