On Tue, 2024-06-25 at 20:30 +0200, Max Krummenacher via lists.openembedded.org wrote: > From: Max Krummenacher <[email protected]> > > When a user of devicetree.bbclass overrides setting S, e.g. to > git/overlays then having UNPACKDIR set to S results in that > git repo unpacked inside UNPACKDIR. Thus the sources are actually > in git/overlays/git/overlays rather than the expected git/overlays. > > Change the logic, so that S by default is set to UNPACKDIR, > but a user can change S to point to were the sources actually > will be. > > Fixes: 7a06069a041a ("devicetree.bbclass: switch away from S = > WORKDIR") > Signed-off-by: Max Krummenacher <[email protected]> > --- > meta/classes-recipe/devicetree.bbclass | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/meta/classes-recipe/devicetree.bbclass b/meta/classes- > recipe/devicetree.bbclass > index 1806cb62cbf7..e5dbd9a85714 100644 > --- a/meta/classes-recipe/devicetree.bbclass > +++ b/meta/classes-recipe/devicetree.bbclass > @@ -40,8 +40,8 @@ PACKAGE_ARCH = "${MACHINE_ARCH}" > SYSROOT_DIRS += "/boot/devicetree" > FILES:${PN} = "/boot/devicetree/*.dtb /boot/devicetree/*.dtbo" > > -S = "${WORKDIR}/sources" > -UNPACKDIR = "${S}" > +UNPACKDIR = "${WORKDIR}/sources" > +S = "${UNPACKDIR}" > B = "${WORKDIR}/build" > > # Default kernel includes, these represent what are normally used > for in-kernel
This doesn't seem to be the right thing to do to me. These settings are really closely related to SRC_URI so I think they probably shouldn't be in the class at all but in the recipes alongside SRC_URI? Cheers, Richard
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#201427): https://lists.openembedded.org/g/openembedded-core/message/201427 Mute This Topic: https://lists.openembedded.org/mt/106875716/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
