Hi Jamin,

Thanks for the patches.

However, I’m getting more convinced that as our FIT generation is spread 
between uboot-sign and kernel-fitimage, maybe we should just create a new class 
that is dedicated to creating a FIT image from arbitrary inputs, so in this 
case you’d have dependencies on tf-a/uboot/kernel and write a dts that 
describes the layout.  I’m unconvinced that the complexity of these classes is 
sustainable and a truly generic class might be a more maintainable alternative.

What’s your opinion on this?  The fact that you had to add custom hooks in 2/3 
seems to indicate that a more inherently flexible class would be the right 
approach.

Cheers,
Ross


> On 18 Nov 2024, at 06:32, Jamin Lin via lists.openembedded.org 
> <[email protected]> wrote:
> 
> v0:
>  1. add variable to set load address and entrypoint.
>  2. Fix to install nonexistent dtb file.
>  3. support to verify signed FIT
>  4. support to load optee-os and TFA images
> v1:
>  Fix patch for code review
> v2:
>  created a series patch
> v3:
>  add cover letter
> v4:
>  Add oe-self testcases for reviewer suggestion
>  Add documentation for reviewer suggestion.
>  Link: 
> https://patchwork.yoctoproject.org/project/docs/patch/[email protected]/
> 
>  The following patches had been applied from v0 changes.
>  a. Fix to install nonexistent dtb file
>  b. support to verify signed FIT
>  c. add variable to set load address and entrypoint.
> 
> Jamin Lin (3):
>  uboot-sign: support to create TEE and ATF image tree source
>  uboot-sign: support to create users specific image tree source
>  oe-selftest: fitimage: add testcases to test ATF and TEE
> 
> meta/classes-recipe/uboot-sign.bbclass   | 100 +++++++-
> meta/lib/oeqa/selftest/cases/fitimage.py | 288 +++++++++++++++++++++++
> 2 files changed, 387 insertions(+), 1 deletion(-)
> 
> -- 
> 2.25.1
> 
> 
> 
> 

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#207991): 
https://lists.openembedded.org/g/openembedded-core/message/207991
Mute This Topic: https://lists.openembedded.org/mt/109640118/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to