Hi Ross
> Subject: Re: [OE-core] [PATCH v4 0/3] uboot-sign: support ATF and TFE ITS
> generation
>
> Hi Jamin,
>
> Thanks for the patches.
>
> However, I’m getting more convinced that as our FIT generation is spread
> between uboot-sign and kernel-fitimage, maybe we should just create a new
> class that is dedicated to creating a FIT image from arbitrary inputs, so in
> this
> case you’d have dependencies on tf-a/uboot/kernel and write a dts that
> describes the layout. I’m unconvinced that the complexity of these classes is
> sustainable and a truly generic class might be a more maintainable
> alternative.
>
> What’s your opinion on this? The fact that you had to add custom hooks in
> 2/3 seems to indicate that a more inherently flexible class would be the right
> approach.
>
Thanks for your review and suggestion.
I agree to create a new bbclass to generate the ITS with users arbitrary inputs.
Could you please give me the following comments?
1. What is the name of this bbclass?
2. This new bbclass should be placed in which directory and meta layer?
3. My briefly proposal of this new bbclass as following, could you please
give me any suggestion?
create_its() {
cat << EOF >> ${UBOOT_ITS}
${USER_FIRMWARE} {
description = ${USER_DESCRIPTION};
data = /incbin/("${UBOOT_FIT_SSP_IMAGE}");
type = ${USER_FIRMWARE};
arch = "${USER_ARCH}";
os = "${USER_OS}";
load = <${USER_LOADADDRESS}>;
entry = <${USER_ENTRYPOINT}>;
compression = ${USER_COMPRESS};
EOF
if [ "${SPL_SIGN_ENABLE}" = "1" ] ; then
cat << EOF >> ${UBOOT_ITS}
signature {
algo = "${UBOOT_FIT_HASH_ALG},${UBOOT_FIT_SIGN_ALG}";
key-name-hint = "${SPL_SIGN_KEYNAME}";
};
EOF
fi
cat << EOF >> ${UBOOT_ITS}
};
EOF
}
Then, users set “USER_XXX” variables to create their own ITS file for
u-boot/kernel FIT image generation.
Or can you give me any suggestion about your goal and ITS improvement?
Thanks-Jamin
> Cheers,
> Ross
>
>
> > On 18 Nov 2024, at 06:32, Jamin Lin via lists.openembedded.org
> <[email protected]> wrote:
> >
> > v0:
> > 1. add variable to set load address and entrypoint.
> > 2. Fix to install nonexistent dtb file.
> > 3. support to verify signed FIT
> > 4. support to load optee-os and TFA images
> > v1:
> > Fix patch for code review
> > v2:
> > created a series patch
> > v3:
> > add cover letter
> > v4:
> > Add oe-self testcases for reviewer suggestion Add documentation for
> > reviewer suggestion.
> > Link:
> > https://patchwork.yoctoproject.org/project/docs/patch/20241118062113.2
> > [email protected]/
> >
> > The following patches had been applied from v0 changes.
> > a. Fix to install nonexistent dtb file b. support to verify signed
> > FIT c. add variable to set load address and entrypoint.
> >
> > Jamin Lin (3):
> > uboot-sign: support to create TEE and ATF image tree source
> > uboot-sign: support to create users specific image tree source
> > oe-selftest: fitimage: add testcases to test ATF and TEE
> >
> > meta/classes-recipe/uboot-sign.bbclass | 100 +++++++-
> > meta/lib/oeqa/selftest/cases/fitimage.py | 288 +++++++++++++++++++++++
> > 2 files changed, 387 insertions(+), 1 deletion(-)
> >
> > --
> > 2.25.1
> >
> >
> >
> >
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#208124):
https://lists.openembedded.org/g/openembedded-core/message/208124
Mute This Topic: https://lists.openembedded.org/mt/109640118/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
