On Wed, 2025-11-12 at 10:13 +0000, Peter Kjellerstedt via lists.openembedded.org wrote: > > -----Original Message----- > > From: [email protected] <openembedded- > > [email protected]> On Behalf Of Ross Burton via > > lists.openembedded.org > > Sent: den 11 november 2025 12:46 > > To: Ming Liu <[email protected]> > > Cc: [email protected] > > Subject: Re: [OE-core] [PATCH V2] bash-completion.bbclass: prepend > > bash- > > completion to PACKAGES > > > > On 11 Nov 2025, at 11:42, Ming Liu <[email protected]> wrote: > > > > > > Hi, Ross: > > > > > > Yes, that should work, but I have to use prepend any way, I am > > > wondering "PACKAGES_BEFORE_PN:prepend " is better than > > > "PACKAGES:prepend”? > > > > Personally I think it’s better because we have a variable that is > > designed > > to be the packages that are collected before PN, so we should use > > it. > > > > Ross > > The reason I suggested to use PACKAGES:prepend rather than > PACKAGE_BEFORE_PN:prepend is that we do not know what is in PACKAGES > and in their FILES variables. However, we do know that the user wants > to package the bash-completion package and thus expects it to claim > its paths regardless of what else is in PACKAGES and FILES. I.e., to > support someone doing something like: > > inherit bash-completion > > PACKAGES =+ "${PN}-foo" > > FILES:${PN}-foo = "${sysconfdir}" > > we need to prepend to PACKAGES rather than PACKAGE_BEFORE_PN.
I'm going to weigh in here. I have a very strong preference not to use prepend/append but just stick with += in the classes. If that means we need to edit the recipes to have the inherit for bash- completion in the right place, so be it. Our recipes are already sensitive to inherit positioning and everything switching to prepend just makes += ultimately useless and moves the problem a level down the line. So we should get ahead of this and just position the inherits correctly. Cheers, Richard
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#226210): https://lists.openembedded.org/g/openembedded-core/message/226210 Mute This Topic: https://lists.openembedded.org/mt/116205797/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
