On Fri, May 8, 2026 at 7:51 PM Joao Marcos Costa <[email protected]> wrote: > > Hello Quentin and Ricardo, > > First, thanks @Ricardo for spotting this v1-instead-of-v2 error! > > On 5/8/26 16:35, Quentin Schulz via lists.openembedded.org wrote: > (...) > > > > This means any recipe including recipes-bsp/u-boot/u-boot-common.inc > > will need to override SRC_URI in addition to SRCREV otherwise the patch > > may not apply. > > It's actually a bit harsher than not applying: > > ERROR: > /src/openembedded-core/meta/recipes-bsp/dummy-u-boot/u-boot-foo_2026.04.foo.bb: > Unable to get checksum for u-boot-foo SRC_URI entry > 0001-scripts-dtc-drop-yaml-in-DT-validation.patch: file could not be found > > so bitbake halts right away, far before do_patch. > > While I agree the v2 was not fully correct, this patch cannot be added > to .inc files, since they may be required by recipes whose FILESPATH > list wouldn't include the patch in the first place.
I don't think it correct to import an .inc and later replace SRCREV without having to also deal with other side effects, and this inc file is really minimal, mostly to set the common recipe-related variables, the dependencies and the source rev for both u-boot and u-boot-tools. We could duplicate these variables per recipe, or create yet another common file based on the version (as suggested by Quentin), but I think it is just an overkill. If you look at how patches were managed here before, they were always included together with SRCREV, as it is OK to expect both to be defined together. Thanks, Ricardo
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#236748): https://lists.openembedded.org/g/openembedded-core/message/236748 Mute This Topic: https://lists.openembedded.org/mt/119204092/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
