devtool finish (and devtool update-recipe in srcrev mode) crashes with
"fatal: bad revision 'AUTOINC'" on any recipe with SRCREV = "${AUTOREV}",
e.g. one created with devtool add --autorev, because the unresolved
AUTOREV placeholder is passed to git format-patch as the base revision
for exporting patches.
Patch 1 uses the initial revision(s) recorded in the workspace bbappend
instead (as patch mode already does), and stops replacing the AUTOREV
with a pinned revision on finish. Patch 2 adds the oe-selftest case
Randy asked for in the bug; it fails with the exact reported error
before patch 1 and passes after.
While investigating I verified this is not a recent regression: the
same crash reproduces on wrynose, whinlatter, scarthgap and kirkstone,
so it most likely dates back to the introduction of --autorev.
Tested on oe-core master in a qemux86-64 build environment:
- devtool add --autorev + devtool finish: fails before, passes after,
finished recipe keeps SRCREV = "${AUTOREV}"
- devtool add (pinned) + devtool finish: unchanged
- oe-selftest -r devtool.DevtoolAddTests.test_devtool_add_git_autorev_finish
(new): PASSED
- oe-selftest -r devtool.DevtoolUpdateTests.test_devtool_update_recipe_git
devtool.DevtoolUpdateTests.test_devtool_update_recipe_append_git: PASSED
[YOCTO #16354]
Babanpreet Singh (2):
devtool: standard: fix finish/update-recipe for recipes using AUTOREV
oeqa/selftest/devtool: add test for finishing a recipe using AUTOREV
meta/lib/oeqa/selftest/cases/devtool.py | 32 +++++++++++++++++++++++++
scripts/lib/devtool/standard.py | 16 +++++++++++--
2 files changed, 46 insertions(+), 2 deletions(-)
--
2.43.0
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#240825):
https://lists.openembedded.org/g/openembedded-core/message/240825
Mute This Topic: https://lists.openembedded.org/mt/120245024/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
