On Mon, 13 Jul 2026, Alexander Kanavin <[email protected]> wrote: > There is no need to add a whole new test that largely copy-pastes > other tests. There is already test_devtool_add_fetch_git(), which adds > a recipe with AUTOREV, but then runs 'reset' instead of 'finish', so > that test should instead be adjusted.
Fair point - the add/check portion did duplicate what that test already does. I'll send a v2 that drops the new test and instead adjust test_devtool_add_fetch_git(). Thanks for the review, Baban On Mon, Jul 13, 2026 06:22 AM, Alexander Kanavin <[email protected]> wrote: > On Mon, 13 Jul 2026 at 08:04, Baban via lists.openembedded.org > <[email protected]> wrote: > > AI-Generated: Uses Claude (claude-sonnet-5) > > + def test_devtool_add_git_autorev_finish(self): > > + # Test that a recipe created by devtool add --autorev can be > finished > > + # into a layer; this used to fail with "fatal: bad revision > 'AUTOINC'" > > + # because the unresolved AUTOREV placeholder was used as the git > > + # revision to export patches from [YOCTO #16354] > > There is no need to add a whole new test that largely copy-pastes > other tests. There is already test_devtool_add_fetch_git(), which adds > a recipe with AUTOREV, but then runs 'reset' instead of 'finish', so > that test should instead be adjusted. > > Alex >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#240859): https://lists.openembedded.org/g/openembedded-core/message/240859 Mute This Topic: https://lists.openembedded.org/mt/120245027/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
