On Fri, 2012-08-03 at 23:43 +0800, Liang Li wrote: > Via EXTRA_CFLAGS, we can pass the sysroot include directory to perf to > provide slang.h rather than hardcoded host dir in perf's Makefile. > > Pass WERROR=0 to perf's Makefile to avoid warnings being treated > as errors. Warnings are not fatal, and while they will be fixed in the > future, there's no need for them to break the build.
No mention of the additional slang dependency is made here? > Signed-off-by: Liang Li <[email protected]> > --- > meta/recipes-kernel/perf/perf_3.4.bb | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/meta/recipes-kernel/perf/perf_3.4.bb > b/meta/recipes-kernel/perf/perf_3.4.bb > index 505c7b8..537e926 100644 > --- a/meta/recipes-kernel/perf/perf_3.4.bb > +++ b/meta/recipes-kernel/perf/perf_3.4.bb > @@ -24,6 +24,7 @@ DEPENDS = "virtual/kernel \ > ${MLPREFIX}binutils \ > ${TUI_DEPENDS} \ > ${SCRIPTING_DEPENDS} \ > + slang \ > " > > SCRIPTING_RDEPENDS = "${@perf_feature_enabled('perf-scripting', 'perl > perl-modules python', '',d)}" > @@ -63,6 +64,8 @@ EXTRA_OEMAKE = \ > AR="${AR}" \ > prefix=/usr \ > NO_GTK2=1 ${TUI_DEFINES} NO_DWARF=1 ${SCRIPTING_DEFINES} \ > + WERROR=0 \ > + EXTRA_CFLAGS=-I${STAGING_INCDIR} \ > ' This is is not acceptable since the include directory /usr/include/slang is still being looked at and this just "hides" the error. STAGING_INCDIR is on the compilers default search path anyway. So this patch is wrong in several different ways :( I've merged a temporary fix until we get this resolved properly. Cheers, Richard _______________________________________________ Openembedded-core mailing list [email protected] http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
