On Tue, 2012-08-07 at 10:07 -0400, Bruce Ashfield wrote: > On 12-08-07 10:02 AM, Richard Purdie wrote: > > On Fri, 2012-08-03 at 23:43 +0800, Liang Li wrote: > >> Via EXTRA_CFLAGS, we can pass the sysroot include directory to perf to > >> provide slang.h rather than hardcoded host dir in perf's Makefile. > >> > >> Pass WERROR=0 to perf's Makefile to avoid warnings being treated > >> as errors. Warnings are not fatal, and while they will be fixed in the > >> future, there's no need for them to break the build. > > > > No mention of the additional slang dependency is made here? > > > >> Signed-off-by: Liang Li<[email protected]> > >> --- > >> meta/recipes-kernel/perf/perf_3.4.bb | 3 +++ > >> 1 file changed, 3 insertions(+) > >> > >> diff --git a/meta/recipes-kernel/perf/perf_3.4.bb > >> b/meta/recipes-kernel/perf/perf_3.4.bb > >> index 505c7b8..537e926 100644 > >> --- a/meta/recipes-kernel/perf/perf_3.4.bb > >> +++ b/meta/recipes-kernel/perf/perf_3.4.bb > >> @@ -24,6 +24,7 @@ DEPENDS = "virtual/kernel \ > >> ${MLPREFIX}binutils \ > >> ${TUI_DEPENDS} \ > >> ${SCRIPTING_DEPENDS} \ > >> + slang \ > >> " > >> > >> SCRIPTING_RDEPENDS = "${@perf_feature_enabled('perf-scripting', 'perl > >> perl-modules python', '',d)}" > >> @@ -63,6 +64,8 @@ EXTRA_OEMAKE = \ > >> AR="${AR}" \ > >> prefix=/usr \ > >> NO_GTK2=1 ${TUI_DEFINES} NO_DWARF=1 ${SCRIPTING_DEFINES} \ > >> + WERROR=0 \ > >> + EXTRA_CFLAGS=-I${STAGING_INCDIR} \ > >> ' > > > > This is is not acceptable since the include directory /usr/include/slang > > is still being looked at and this just "hides" the error. STAGING_INCDIR > > is on the compilers default search path anyway. > > But this makes it first, which is what we were going for. For > an external toolchain, this also might not be true.
You have an external toolchain which does not search the sysroot usr/include directory? Really? ;-) I accept we won't search usr/include/slang but we don't install slang in that directory anyway so its irrelevant and that isn't the path you're adding. > > So this patch is wrong in several different ways :( > > > > I've merged a temporary fix until we get this resolved properly. > > I think this is a point of view thing, since from here, this is a > better temporary fix than commenting out the path in the perf > Makefile, which will break standalone tree cases if I merge the patch > into the tree, and I don't want to go to a milestone freeze with > an out of tree patch. I doubt it will actually break anything. > So I'd ask again that we reconsider this patch, since what's in tree > has issues with other use cases. No, I'm flatly refusing it, sorry. Cheers, Richard _______________________________________________ Openembedded-core mailing list [email protected] http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
