Hi Qi, On Thursday 11 July 2013 19:11:36 [email protected] wrote: > From: Chen Qi <[email protected]> > > This patchset mainly does two things: > 1. code refactor to avoid code duplication > 2. add a method for image level user/group configuration > > The following changes since commit a63229917a5708de2d161aba0d67168ce0da6365: > > meta-yocto-bsp: update reference board SRCREVs (2013-07-10 09:45:51 +0100) > > are available in the git repository at: > > git://git.pokylinux.org/poky-contrib ChenQi/user_group_settings > > http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=ChenQi/user_group_set > tings > > Chen Qi (3): > userbase.bbclass: add a new bbclass > useradd.bbclass: code refactor > usersettings.bbclass: add a new bbclass > > meta/classes/useradd.bbclass | 103 ++--------------- > meta/classes/userbase.bbclass | 230 > +++++++++++++++++++++++++++++++++++++ meta/classes/usersettings.bbclass | > 48 ++++++++ > 3 files changed, 290 insertions(+), 91 deletions(-) > create mode 100644 meta/classes/userbase.bbclass > create mode 100644 meta/classes/usersettings.bbclass
In terms of naming I'd rather see the base class be called useradd_base to match the naming of similar existing classes. For the new class, I'm not sure usersettings is really an appropriate name, perhaps something like "useradd_real" or "useraccount" or something else that more accurately reflects what it is for? Cheers, Paul -- Paul Eggleton Intel Open Source Technology Centre _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
