On Thursday 11 July 2013 13:58:17 Paul Eggleton wrote: > On Thursday 11 July 2013 19:11:39 [email protected] wrote: > > +IMAGE_INSTALL_append += "${@['', 'base-passwd > > shadow'][bool(d.getVar('USER_GROUP_SETTINGS', True))]}" > > This is a bit ugly. We should avoid using _append += since it is confusing, > and we have base_conditional for things like this. I'd suggest: > > IMAGE_INSTALL_append = "${@base_conditional('USER_GROUP_SETTINGS', '1', ' > base-passwd shadow', '', d)}"
Actually reading this again I've misinterpreted what it's supposed to be doing. Unfortunately I don't think we have a neat base_ifset() or similar so perhaps this will need to be left as-is. I still think we should avoid _append += however. Cheers, Paul -- Paul Eggleton Intel Open Source Technology Centre _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
