Just in case the severity is not clear. Without this change, the Yocto SDK breaks the build for our software since we do prefer to use ccache for speeding the build process up. We are probably not alone with that ...
On Mon, Sep 1, 2014 at 6:34 PM, Laszlo Papp <[email protected]> wrote: > It is indeed nit, and not something I wishfully spend my time with, so > feel free to rewrite the commit message and integrate the ccache > support. As usual, this feature is also applied in our fork, so I am > fine... It is only the upstream Yocto users who may be missing > features out. > > Having said that, thank you for your feedback. > > On Fri, Aug 29, 2014 at 7:29 PM, Saul Wold <[email protected]> wrote: >> >> Might be a nit, but can you please follow the Commit Guildlines at >> http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines >> >> The summary should include the filename or area of the fix >> >> toolchain-script: Add ... >> >> Also can you expand on the why this is needed? >> >> Thanks >> Sau! >> >> >> On 08/22/2014 08:20 AM, Laszlo Papp wrote: >>> >>> Signed-off-by: Laszlo Papp <[email protected]> >>> --- >>> meta/classes/toolchain-scripts.bbclass | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/meta/classes/toolchain-scripts.bbclass >>> b/meta/classes/toolchain-scripts.bbclass >>> index 6cc8eba..60278d6 100644 >>> --- a/meta/classes/toolchain-scripts.bbclass >>> +++ b/meta/classes/toolchain-scripts.bbclass >>> @@ -19,6 +19,7 @@ toolchain_create_sdk_env_script () { >>> >>> EXTRAPATH="$EXTRAPATH:${SDKPATHNATIVE}${bindir_nativesdk}/${TARGET_ARCH}${TARGET_VENDOR}-$i" >>> done >>> echo 'export >>> PATH=${SDKPATHNATIVE}${bindir_nativesdk}:${SDKPATHNATIVE}${bindir_nativesdk}/${TARGET_SYS}'$EXTRAPATH':$PATH' >>> >> $script >>> + echo 'export >>> CCACHE_PATH=${SDKPATHNATIVE}${bindir_nativesdk}:${SDKPATHNATIVE}${bindir_nativesdk}/${TARGET_SYS}'$EXTRAPATH':$CCACHE_PATH' >>> >> $script >>> echo 'export PKG_CONFIG_SYSROOT_DIR=$SDKTARGETSYSROOT' >> $script >>> echo 'export >>> PKG_CONFIG_PATH=$SDKTARGETSYSROOT'"$libdir"'/pkgconfig' >> $script >>> echo 'export >>> CONFIG_SITE=${SDKPATH}/site-config-'"${multimach_target_sys}" >> $script >>> @@ -37,6 +38,7 @@ toolchain_create_tree_env_script () { >>> rm -f $script >>> touch $script >>> echo 'export PATH=${STAGING_DIR_NATIVE}/usr/bin:${PATH}' >> >>> $script >>> + echo 'export >>> CCACHE_PATH=${STAGING_DIR_NATIVE}/usr/bin:${CCACHE_PATH}' >> $script >>> echo 'export PKG_CONFIG_SYSROOT_DIR=${PKG_CONFIG_SYSROOT_DIR}' >> >>> $script >>> echo 'export PKG_CONFIG_PATH=${PKG_CONFIG_PATH}' >> $script >>> echo 'export CONFIG_SITE="${@siteinfo_get_files(d)}"' >> $script >>> >> -- _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
