On 5 September 2014 15:55, Dan McGregor <danismostlik...@gmail.com> wrote:
> On 5 September 2014 03:14, Burton, Ross <ross.bur...@intel.com> wrote:
>> On 3 September 2014 20:57, Dan McGregor <danismostlik...@gmail.com> wrote:
>>>   sed -i -e 's:=/root:=${ROOT_HOME}:g' ${S}/units/*.service*
>>> + sed -i -e 's:"/root":"${ROOT_HOME}":g' \
>>> +        ${S}/src/core/unit-printf.c \
>>> +        ${S}/src/nspawn/nspawn.c \
>>> +        ${S}/src/shared/util.c
>>
>> Sedding service files is one thing, but entire C files is another.
>> Can you please sent this change as a patch to the source?  FWIW for
>> patches where the context isn't that relevant I've started using
>> patches without the context lines so there's more chance of them
>> applying in future releases.
>
> I thought that myself, but ${ROOT_HOME} is a variable. I think to do
> that a patch would
> need to make the root home directory configurable, and not simply
> hardcode it. That shouldn't
> be too hard to do. I'll do that later tonight.

Sed the patch? :)

Creative solutions welcome, I'm just wary of such loose seds in source
code.  If the only sane way is to sed then that's what we'll have to
do.

Ross
-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Reply via email to