On Tue, Aug 11, 2015 at 12:23 AM, Bruce Ashfield <bruce.ashfi...@gmail.com> wrote: > On Mon, Aug 10, 2015 at 11:21 AM, Stefan Müller-Klieser > <s.mueller-klie...@phytec.de> wrote: >> commit 02d0a003d60326 [kernel.bbclass: Fix race condition] has surfaced >> a bug in the generation of the shared_workdir. The task >> do_compile_kernelmodules adds the exported symbols of the kernel modules >> to the Module.symvers. By creating the shared_workdir before the modules >> are compiled, the symbols of the modules are missing in the >> shared_workdir. Subsequent external module builds will not include the >> ABI CRC of functions exported in modules. Modprobe will fail to load the >> external module if CONFIG_MODVERSIONS is enabled.\ > > Have you seen our bug: https://bugzilla.yoctoproject.org/show_bug.cgi?id=8127 > ? > > It's new .. so probably not. > > The significant issue with this, is that we are now forcing anyone > that needs the > shared workdir artifacts to build kernel modules. > > That's performance issue for many workflows. > > I had some changes where I was working to short cut parts of the process, but > they turned out to miss a few corner cases. > > We need to do more thinking on this one, before we can bring in a change like > this .. since avoiding that overhead is something valuable.
I agree that performance is important but correctness seems more valuable for me. I think the optimization can come as a subsequent patch ... -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core