Paul Menzel <[email protected]> writes:

>> From: Enrico Scholz <[email protected]>
>
> it seems you need to update your Git configuration to your common
> email address.

Both addresses are in use; some patches are created at home when I work
on a personal project (-> tu-chemnitz.de address), some patches at work
(-> sigma-chemnitz.de address).


> The diff could have been smaller, but no big problem.

how? three places must be changed (removal of $(LIBS) from old LINKFLAGS,
removal of superflous ';' and adding of $(LIBS) to link command).


>> +-SHLIB_OBJ= $(addprefix shared/, $(LIB_OBJ));
>> ++SHLIB_OBJ= $(addprefix shared/, $(LIB_OBJ))
>
> The »;« was superfluous, since no command followed?

yes; and it would break the build because it terminates the $(CC) command
and $(LIBS) would be interpreted as the start of a new command.

>> ++   $(CC) $(LDFLAGS) -o $(SHLIB) $(SHLINKFLAGS) $(SHLIB_OBJ) $(LIBS)


> Is this patch already upstream?

woglinde gave his ack on irc and I submitted it.



Enrico

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Reply via email to