Am Dienstag, den 26.04.2011, 15:53 +0200 schrieb Enrico Scholz: > Paul Menzel <[email protected]> writes: > > >> From: Enrico Scholz <[email protected]> > > > > it seems you need to update your Git configuration to your common > > email address. > > Both addresses are in use; some patches are created at home when I work > on a personal project (-> tu-chemnitz.de address), some patches at work > (-> sigma-chemnitz.de address).
I guessed as much. But your Signed-off-by line differs from the From line. Additionally for the commit statistics it would be better to use a common address so that all your commits are shown under one person. The second reason is just for convenience reasons. > > The diff could have been smaller, but no big problem. > > how? three places must be changed (removal of $(LIBS) from old LINKFLAGS, > removal of superflous ';' and adding of $(LIBS) to link command). I meant just the header of the diff in the patch. > >> +-SHLIB_OBJ= $(addprefix shared/, $(LIB_OBJ)); > >> ++SHLIB_OBJ= $(addprefix shared/, $(LIB_OBJ)) > > > > The »;« was superfluous, since no command followed? > > yes; and it would break the build because it terminates the $(CC) command > and $(LIBS) would be interpreted as the start of a new command. Thank you for the explanation. > >> ++ $(CC) $(LDFLAGS) -o $(SHLIB) $(SHLINKFLAGS) $(SHLIB_OBJ) $(LIBS) > > > Is this patch already upstream? > > woglinde gave his ack on irc For documentation purpose it would be great if you could add such acknowledgments to the commit message. > and I submitted it. But I meant upstream of TCP Wrapper. Thank you for the explanation and your patches, Paul
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Openembedded-devel mailing list [email protected] http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
