Dear Eric,
Am Mittwoch, den 04.05.2011, 18:57 +0200 schrieb Eric Bénard: > On 04/05/2011 18:48, Paul Menzel wrote: > > Am Mittwoch, den 04.05.2011, 17:34 +0200 schrieb Eric Bénard: > >> On 04/05/2011 10:56, Paul Menzel wrote: > >>> Please remember to add what build configuration you used. (You can just > >>> paste it from the BitBake output.) > >> > >> You asked this several times on the list but this part is not in the commit > >> log policy : http://wiki.openembedded.org/index.php/Commit_log_example > > > > I know and therefore I do *not* NACK patches and even commit them if the > > build configuration is not in the commit message. Still I think it > > belongs to useful commit messages to be able to reproduce something and > > therefore I am asking for it. > > > maybe this information could go under the commit log, between two --- lines > as > this makes git log more difficult to read and this information in mostly > useful for patch review. In my opinion it is not so important for the review but for later bug tracking. Take the following example. $ git log recipes/prboom/ Why did those compilation fixes needed to be applied. Knowing what distribution and machine was used I could conclude what other versions of recipes were used and do some debugging. Thanks, Paul
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Openembedded-devel mailing list [email protected] http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
