On 30.08.2011 14:30, Paul Menzel wrote: > Am Dienstag, den 30.08.2011, 12:51 +0200 schrieb Steffen Sledz: >> On 25.08.2011 16:09, Steffen Sledz wrote: >>> On 25.08.2011 12:59, Steffen Sledz wrote: >>>> On 24.08.2011 17:22, Jesse Gilles wrote: >>>>> On Tue, 2011-08-23 at 13:16 -0400, George C. Huntington, III wrote: >>>>>> I suspect that the problem is happening earlier, classpath isn't >>>>>> building. >>>>>> the javac wrapper eats the return code from a java compile. >>>>> >>>>> If George is right, then the following patch to the javac wrapper script >>>>> may fix the issue. It fixes building classpath as well as returns the >>>>> error code if all javac attempts fail. >>>>> >>>>> http://patches.openembedded.org/patch/9521/ >>>> >>>> In our case this patch helps. >>>> >>>> If nobody has objections i will commit this patch to oe-dev master and >>>> request a pull to 2011.03-maintenance. >>> >>> It would be still better if we can get some Acks from a java maintainer. >> >> No NACKs after another week. So i pushed the patch do oe-dev master. > > Next time it would be better to resend the patch with a appropriate > subject line. > > Unfortunately the commit message [1] does not conform to our commit > policy [2]. > > Please make sure to check those things next time. I feel uncomfortable > to ask new contributors to comply every time but when they look at the > commit history they see that the policies are often not cared about.
Mea culpa. I should have asked the contributor to resend the patch with a policy conforming comment. Sorry. Do we still have a chance to change the comment if the patch was already pushed? Steffen > [1] > http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=16a8a1e9175035b55d91a141d5302c38d63c16f1 > [2] http://openembedded.org/index.php/Category:Policy -- DResearch Fahrzeugelektronik GmbH Otto-Schmirgal-Str. 3, 10319 Berlin, Germany Tel: +49 30 515932-237 mailto:[email protected] Fax: +49 30 515932-299 Geschäftsführer: Dr. Michael Weber, Werner Mögle; Amtsgericht Berlin Charlottenburg; HRB 130120 B; Ust.-IDNr. DE273952058 _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
