Hey Alex, the whole mail is the patch. I send it via git send-email and there is the signed off line in it. But I can attach it and send it manually with my mail program if the git send-email thing is no good.
Regards, Thilo Am Mittwoch, den 16.11.2016, 17:27 +0200 schrieb Alexander Kanavin: > On 11/16/2016 12:23 PM, Thilo Cestonaro wrote: > > to fix the build, two patches where needed. > > > > One which just adds an include of unistd.h, as the functions pipe, write and > > close defined by this include, weren't defined. > > > > The other patch enables the build to build the tools of libdbus-c++ for the > > target, which, without the patch, will always be build for the host, even > > when > > cross compiling. > > You need to include this information on top of the patch files > themselves. So that when people look at the patches, they can > immediately see what they are for, without digging through commit > history. And also patches are still missing Upstream-Status, and > Signed-off-by lines (I asked you about it earlier). Have a look at any > other recipe patch in oe-core to see how it should look like. > > Do read http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines > please. > > Alex >
smime.p7s
Description: S/MIME cryptographic signature
-- _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-devel
