Hi Tim, Thanks for reviewing.
On 01/04/2018 04:44 PM, Tim Orling wrote: > >> On Jan 4, 2018, at 8:06 AM, Ricardo Silva <[email protected]> wrote: >> >> The pycrypto module sources can be used for both python2 and python3, >> but a recipe for python3 was missing, so add it. >> >> Recipe is basically the same as for python2 (python-pycrypto_2.6.1.bb), >> but using distutils3 instead. >> >> Signed-off-by: Ricardo Silva <[email protected]> >> --- >> .../recipes-devtools/python/python3-pycrypto_2.6.1.bb | 13 >> +++++++++++++ >> 1 file changed, 13 insertions(+) >> create mode 100644 >> meta-python/recipes-devtools/python/python3-pycrypto_2.6.1.bb >> >> diff --git a/meta-python/recipes-devtools/python/python3-pycrypto_2.6.1.bb >> b/meta-python/recipes-devtools/python/python3-pycrypto_2.6.1.bb >> new file mode 100644 >> index 000000000..2878c8599 >> --- /dev/null >> +++ b/meta-python/recipes-devtools/python/python3-pycrypto_2.6.1.bb >> @@ -0,0 +1,13 @@ >> +inherit distutils3 >> +require python-pycrypto.inc >> + >> +SRC_URI += "file://cross-compiling.patch \ >> + file://CVE-2013-7459.patch \ >> + > > These will not be picked up as they are in "python-pycrypto" directory (not > in “files” or “python3-pycrypto”, etc.). This will result in a fetcher > failure. You're right. I had a leftover files that made my tests pass. Should have tested with a clean tree. > > Rather than duplicate the SRC_URI in both python2- and python3- recipes, we > should add them to python-pycrypto.inc and add the following to > python-pycrypto.inc > > FILESEXTRAPATHS_prepend := "${THISDIR}/python-pycrypto:” > Agree. Shall I send a v2 with your suggested changes? Regards, Ricardo Silva -- _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-devel
