> On Jan 4, 2018, at 9:27 AM, Ricardo Silva <[email protected]> wrote:
>
> Hi Tim,
>
> On 01/04/2018 04:56 PM, Tim Orling wrote:
>>
>>> On Jan 4, 2018, at 8:51 AM, Ricardo Silva <[email protected]> wrote:
>>>
>>>>
>>>> Rather than duplicate the SRC_URI in both python2- and python3- recipes,
>>>> we should add them to python-pycrypto.inc and add the following to
>>>> python-pycrypto.inc
>>>>
>>>> FILESEXTRAPATHS_prepend := "${THISDIR}/python-pycrypto:”
>>>>
>>>
>>> Agree.
>>> Shall I send a v2 with your suggested changes?
>>>
>>
>> Yes, please. If you don’t mind (it will need to remove the extra SRC_URI
>> lines from python2 recipe, add the SRC_URI lines and FILESEXTRAPATHS to .inc
>> and then add the python3 recipe).
>
> Glad to. You mean the changes should be split over a patch series, or OK
> to have a single patch with all the changes?
>
Single patch touching all three files is fine.
> Also note that the .inc file already had :
> FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
> so I would just change that to:
> FILESEXTRAPATHS_prepend := "${THISDIR}/python-pycrypto:”
>
Correct. As ${PN} would resolve to python3-pycrypto and not work as intended :)
> Regards,
>
> Ricardo Silva
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel