While digging around this, I noticed that BLUEZ is set depending on DISTRO_FEATURES only, wouldn't it make more sense to check COMBINED_FEATURES instead ?
Le mer. 17 oct. 2018 à 23:34, Martin Jansa <[email protected]> a écrit : > I wouldn't say that supporting bluez6 as BLUEZ value before > RDEPENDS_bluez6 is defined here is really better. > > Whole bluez4 support here is a bit useless considering that all bluez4 > related recipes were removed more than a year ago with: > > commit 007498ac72e26e9f7064de74f7fe96e91ae6c969 > Author: Martin Jansa <[email protected]> > Date: Mon Jul 24 19:25:35 2017 +0200 > > bluez4: remove bluez4-only recipes > > > On Wed, Oct 17, 2018 at 11:20 PM Peter Kjellerstedt < > [email protected]> wrote: > >> > -----Original Message----- >> > From: [email protected] < >> [email protected]> On Behalf Of >> [email protected] >> > Sent: den 17 oktober 2018 22:57 >> > To: [email protected] >> > Cc: Yann Dirson <[email protected]> >> > Subject: [oe] [PATCH v3] packagegroup-tools-bluetooth: work as >> advertized on distro without bluez* support >> > >> > From: Yann Dirson <[email protected]> >> > >> > Otherwise the build fails with: >> > >> > NOTE: Runtime target '${RDEPENDS_}' is unbuildable, removing... >> > Missing or unbuildable dependency chain was: ['${RDEPENDS_}'] >> > >> > This restores some truth in the "Otherwise install nothing" comment in >> > the recipe. >> > >> > Signed-off-by: Yann Dirson <[email protected]> >> > --- >> > .../packagegroups/packagegroup-tools-bluetooth.bb | 5 ++++- >> > 1 file changed, 4 insertions(+), 1 deletion(-) >> > >> > diff --git a/meta-oe/recipes-connectivity/packagegroups/ >> packagegroup-tools-bluetooth.bb >> b/meta-oe/recipes-connectivity/packagegroups/ >> packagegroup-tools-bluetooth.bb >> > index 0ede5e57b..207c7c1ae 100644 >> > --- a/meta-oe/recipes-connectivity/packagegroups/ >> packagegroup-tools-bluetooth.bb >> > +++ b/meta-oe/recipes-connectivity/packagegroups/ >> packagegroup-tools-bluetooth.bb >> > @@ -34,4 +34,7 @@ RDEPENDS_bluez5 = " \ >> > >> > # Install bluez4 tools or bluez5 tools depending on what is specified >> in the distro. >> > # Otherwise install nothing. >> > -RDEPENDS_${PN} = "${RDEPENDS_${BLUEZ}}" >> > +RDEPENDS_${PN} = " \ >> > + ${@'${RDEPENDS_bluez5}' if d.getVar('BLUEZ', True) == 'bluez5' >> else ''} \ >> > + ${@'${RDEPENDS_bluez4}' if d.getVar('BLUEZ', True) == 'bluez4' >> else ''} \ >> > +" >> >> You can simplify this (and support any value of ${BLUEZ} just in >> case someone decides to add bluez6): >> >> RDEPENDS_${PN} = "${@'${RDEPENDS_${BLUEZ}}' if d.getVar('BLUEZ') else ''}" >> >> Also, the second argument to d.getVar() has defaulted to True for >> a long time, so no point in specifying it. >> >> > -- >> > 2.19.1 >> >> //Peter >> >> -- >> _______________________________________________ >> Openembedded-devel mailing list >> [email protected] >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel >> > -- Yann Dirson <[email protected]> Blade -- 38 rue du Sentier, 75002 Paris -- _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-devel
