On Wed, Oct 17, 2018 at 10:03:53PM +0000, Peter Kjellerstedt wrote: > > -----Original Message----- > > From: [email protected] <openembedded- > > [email protected]> On Behalf Of Martin Jansa > > Sent: den 17 oktober 2018 23:34 > > To: Peter Kjellerstedt <[email protected]> > > Cc: [email protected]; openembedded-devel <openembedded- > > [email protected]> > > Subject: Re: [oe] [PATCH v3] packagegroup-tools-bluetooth: work as > > advertized on distro without bluez* support > > > > I wouldn't say that supporting bluez6 as BLUEZ value before > > RDEPENDS_bluez6 is defined here is really better. > > Well, my point was that rewriting it according to my suggestion > makes it agnostic to whatever value the ${BLUEZ} variable has.
And my point is that it doesn't make it better, because it will do
something useful only with RDEPENDS_bluez4 or RDEPENDS_bluez5, adding
dependency on undefined ${RDEPENDS_whatever} doesn't really help, does
it?
> > Whole bluez4 support here is a bit useless considering that all bluez4
> > related recipes were removed more than a year ago with:
> >
> > commit 007498ac72e26e9f7064de74f7fe96e91ae6c969
> > Author: Martin Jansa <[email protected]>
> > Date: Mon Jul 24 19:25:35 2017 +0200
> >
> > bluez4: remove bluez4-only recipes
> >
> >
> > On Wed, Oct 17, 2018 at 11:20 PM Peter Kjellerstedt <
> > [email protected]> wrote:
> >
> > > > -----Original Message-----
> > > > From: [email protected] <
> > > [email protected]> On Behalf Of
> > > [email protected]
> > > > Sent: den 17 oktober 2018 22:57
> > > > To: [email protected]
> > > > Cc: Yann Dirson <[email protected]>
> > > > Subject: [oe] [PATCH v3] packagegroup-tools-bluetooth: work as
> > > advertized on distro without bluez* support
> > > >
> > > > From: Yann Dirson <[email protected]>
> > > >
> > > > Otherwise the build fails with:
> > > >
> > > > NOTE: Runtime target '${RDEPENDS_}' is unbuildable, removing...
> > > > Missing or unbuildable dependency chain was: ['${RDEPENDS_}']
> > > >
> > > > This restores some truth in the "Otherwise install nothing" comment
> > in
> > > > the recipe.
> > > >
> > > > Signed-off-by: Yann Dirson <[email protected]>
> > > > ---
> > > > .../packagegroups/packagegroup-tools-bluetooth.bb | 5
> > ++++-
> > > > 1 file changed, 4 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/meta-oe/recipes-connectivity/packagegroups/
> > > packagegroup-tools-bluetooth.bb
> > > b/meta-oe/recipes-connectivity/packagegroups/
> > > packagegroup-tools-bluetooth.bb
> > > > index 0ede5e57b..207c7c1ae 100644
> > > > --- a/meta-oe/recipes-connectivity/packagegroups/
> > > packagegroup-tools-bluetooth.bb
> > > > +++ b/meta-oe/recipes-connectivity/packagegroups/
> > > packagegroup-tools-bluetooth.bb
> > > > @@ -34,4 +34,7 @@ RDEPENDS_bluez5 = " \
> > > >
> > > > # Install bluez4 tools or bluez5 tools depending on what is
> > specified
> > > in the distro.
> > > > # Otherwise install nothing.
> > > > -RDEPENDS_${PN} = "${RDEPENDS_${BLUEZ}}"
> > > > +RDEPENDS_${PN} = " \
> > > > + ${@'${RDEPENDS_bluez5}' if d.getVar('BLUEZ', True) == 'bluez5'
> > else
> > > ''} \
> > > > + ${@'${RDEPENDS_bluez4}' if d.getVar('BLUEZ', True) == 'bluez4'
> > else
> > > ''} \
> > > > +"
> > >
> > > You can simplify this (and support any value of ${BLUEZ} just in
> > > case someone decides to add bluez6):
> > >
> > > RDEPENDS_${PN} = "${@'${RDEPENDS_${BLUEZ}}' if d.getVar('BLUEZ') else ''}"
> > >
> > > Also, the second argument to d.getVar() has defaulted to True for
> > > a long time, so no point in specifying it.
> > >
> > > > --
> > > > 2.19.1
> > >
> > > //Peter
>
> //Peter
>
--
Martin 'JaMa' Jansa jabber: [email protected]
signature.asc
Description: Digital signature
-- _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-devel
