Review: Needs Fixing to be improved: 1. Move the function to proper class, it will be good to move it to account.tax.template 2. please don't relay on the context values for the main flow of the function, it can be easily done by adding an extra keyword argument 3. It will be good to move the special operations for 'wizard.multi.charts.accounts' will be done in methods of that class only instead of the generic function 4. Also add some good label in the wizard, and docstring in the function
thanks -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-l10n-control-dev-add-wizard-togenerate-tax-from-template-ron/+merge/70435 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-l10n-control-dev. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
