Review: Disapprove

Instead of being arbitrarily hidden this way, I think it should be structurally 
fixed: the relevant link is in the ViewManager's template, so the O2M 
viewmanager gets it, but the shortcuts management code is only in 
ViewManagerAction.

ViewManager should not have the shortcut link at all, and instead 
ViewManagerAction should override ViewManager's template and add the shortcut 
star at the right place. That way, only views openened from an act_window 
action (via a ViewManager) would be shortcut-able, which is (I think) sensible.
-- 
https://code.launchpad.net/~openerp-dev/openerp-web/trunk-bug-842545-vda/+merge/74413
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openerp-web/trunk-bug-842545-vda.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to