Review: Needs Fixing
some improvements:
13 + picking_id = self.search(cr, uid, []) => It will search & cancel all
the picking
34 + Changes the Quantity of Product. => It seems you have changed the qty
after do produce, this is not correct, use this wizard for the states on which
the button is available
line 29, 59 and 83 => Correct the statements
92 + assert order_id, _('No Work order!') => Improve warning message
104 + pick_ids = self.search(cr, uid,
[('state','!=','done'),('type','=','internal')])
105 + assert pick_ids, _('No Internal Pickings!')
=> this will find all the internal pickings having state done, here we need
to find picking related to our MO
135-143 and 151-159 => these changes are not needed
179 + self._production_date_end(cr, uid, [ref("mrp_production_mo0")], prop,
unknow_none, context=None)
=> no need for intermediate variables prop and unknow_none
please improve yml of mrp_repair to follow proper flow
thanks
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-mrp-coverage-new-ksa/+merge/76212
Your team OpenERP R&D Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-mrp-coverage-new-ksa.
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp
